You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:
Is the problem being addressed significant enough to warrant a change to SDL?
Does this proposal fit well with the feel and direction of SDL?
If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
Please state explicitly whether you believe that the proposal should be accepted into SDL.
More information about the SDL evolution process is available at
To me the proposal looks good. I guess HD radio enable only makes sense with RadioBand.XM otherwise it's ignored?
Don't want to be fussy... but changing the maxvalue would be a signature change. The xml should be like (expecting version 5.0 comes after 4.5):
<paramname="availableHDs"type="Integer"minvalue="1"maxvalue="7"mandatory="false"since="5.0">
<description>number of HD sub-channels if available</description>
<history>
<paramname="availableHDs"type="Integer"minvalue="1"maxvalue="3"mandatory="false"since="4.5"until="4.5" />
</history>
</param>
<paramname="hdChannel"type="Integer"minvalue="1"maxvalue="7"mandatory="false"since="5.0">
<description>Current HD sub-channel if available</description>
<history>
<paramname="hdChannel"type="Integer"minvalue="1"maxvalue="3"mandatory="false"since="4.5"until="4.5">
</history>
</param>
theresalech
changed the title
[In Review] SDL 0160 - Remote Control Radio Parameter Update
[Accepted] SDL 0160 - Remote Control Radio Parameter Update
Apr 25, 2018
Hello SDL community,
The review of "Remote Control Radio Parameter Update" begins now and runs through April 24, 2018. The proposal is available here:
https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0160-rc-radio-parameter-update.md
Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:
#464
What goes into a review?
The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:
Please state explicitly whether you believe that the proposal should be accepted into SDL.
More information about the SDL evolution process is available at
https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md
Thank you,
Theresa Lech
Program Manager - Livio
[email protected]
The text was updated successfully, but these errors were encountered: