Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accepted] SDL 0102 - New vehicle data - ElectronicParkBrakeStatus #303

Closed
theresalech opened this issue Sep 27, 2017 · 4 comments
Closed

Comments

@theresalech
Copy link
Contributor

theresalech commented Sep 27, 2017

Hello SDL community,

The review of "New vehicle data - ElectronicParkBrakeStatus" begins now and runs through October 3, 2017. The proposal is available here:

https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0102-New-vehicle-data-ElectronicParkBrakeStatus.md

Reviews are an important part of the SDL evolution process. All reviews should be sent to the associated Github issue at:

#303

What goes into a review?

The goal of the review process is to improve the proposal under review through constructive criticism and, eventually, determine the direction of SDL. When writing your review, here are some questions you might want to answer in your review:

  • Is the problem being addressed significant enough to warrant a change to SDL?
  • Does this proposal fit well with the feel and direction of SDL?
  • If you have used competitors with a similar feature, how do you feel that this proposal compares to those?
  • How much effort did you put into your review? A glance, a quick reading, or an in-depth study?
    Please state explicitly whether you believe that the proposal should be accepted into SDL.

More information about the SDL evolution process is available at

https://github.com/smartdevicelink/sdl_evolution/blob/master/process.md

Thank you,
Theresa Lech

Program Manager - Livio
[email protected]

@Jack-Byrne
Copy link
Contributor

Jack-Byrne commented Oct 3, 2017

Looks good to me. Only question I have for other SDLC members is if they are ok with the following defined enums

<enum name="EletronicParkBrakeStatus">
  <element name="CLOSED" />
    <description>
      Park brake actuators have been fully applied.
    </description>		
    </element>
  <element name="TRANSITION">
    <description>
      Park brake actuators are transitioning to either Apply/Closed or Release/Open state.
    </description>
  </element>
  <element name="OPEN">
    <description>
      Park brake actuators are released.
    </description>		
  </element>
  <element name="DRIVE_ACTIVE">
    <description>
      When driver pulls the Electronic Park Brake switch while driving "at speed".
    </description>
  </element>
 <element name="FAULT">
    <description>
      When system has a fault or is under maintenance.
    </description>
 </element>
</enum>

@theresalech
Copy link
Contributor Author

During the Steering Committee meeting on October 3 (2017-10-03), the Steering Committee voted to defer this proposal, keeping it in review until our next meeting on October 10, 2017. This will allow members additional time to confirm the enum definitions with their appropriate departments, as it will be important to ensure definitions work for all members and avoid changing them in the future.

@theresalech theresalech changed the title [In Review] SDL 0102 - New vehicle data - ElectronicParkBrakeStatus [Accepted] SDL 0102 - New vehicle data - ElectronicParkBrakeStatus Oct 11, 2017
@theresalech
Copy link
Contributor Author

The Steering Committee fully agreed to accept this proposal and the enums defined in the comment left by JackLivio on this review issue.

@smartdevicelink smartdevicelink locked and limited conversation to collaborators Oct 11, 2017
@theresalech
Copy link
Contributor Author

Issues Entered:
Core
iOS
Android
RPC

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants