Fix/sdl 3620 SDL does not respond with NACK to start RPC service request with invalid data #3647
Conversation
…oad. Fix memory leak with session after Start RPC service NACK. Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode. Fix NACK sending for Start any service with non-existent session id.
|
@JackLivio this PR is ready for review |
| const SessionContext& context, | ||
| SessionContext& context, |
There was a problem hiding this comment.
unfortunately this is not allowed on a public method.
to change this parameter to non-const we need to mark this method as DEPRECATED and define a new method with the new signature.
|
@VladSemenyuk please see the comment above. Thanks! |
…on payload. Fix memory leak with session after Start RPC service NACK. Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode. Fix NACK sending for Start any service with non-existent session id.
@jordynmackool comments have been processed here |
| NotifySessionStarted( | ||
| const_cast<SessionContext&>(context), rejected_params, err_reason); |
There was a problem hiding this comment.
I fear this will cause undefined behavior if called with a const context.
We need to preserve the old functionality (of calling with a const context) until a major version bump.
There was a problem hiding this comment.
@iCollin agree, it's unsafe code. I replaced this cast with the local copy of the same context. As const version of deprecated function is not supposed to change the context, but supposed to use the same callbacks, I believe we can work in this way - 58fb660
Note, that deprecated function is unused for now.
…a in bson payload. Fix memory leak with session after Start RPC service NACK. Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode. Fix NACK sending for Start any service with non-existent session id.
Fixes #3620
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
ATF, Unit tests
Summary
Fix memory leak with session after Start RPC service NACK.
Fix OnServiceUpdate sending after Start RPC service with invalid data in bson payload for protected mode.
Fix NACK sending for Start any service with non-existent session id.
Bug Fixes
Start RPC service with invalid data in bson payload
not send StartServiceNack to mobile app
session added in SDL Connection handler(memory leak)
Start RPC service with not null session id(except for RPC start service for protected mode)
not send StartServiceNack to mobile app
Start any service with non-existent session id(existent session ids are returned in RPC StartServiceAck)
not send StartServiceNack to mobile app
Start RPC service with invalid data in bson payload for protected mode
not send 'OnServiceUpdate' notification to HMI with 'REQUEST_REJECTED'
Start RPC service for protected mode before HMI has provided BC.OnSystemTimeReady notification
not send 'OnServiceUpdate' notification to HMI with 'REQUEST_REJECTED'
CLA