Fix/ Postpone application activation if registration is not complete yet #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theresalech This PR is ready for Livio review. Thank you! |
iCollin
reviewed
Oct 29, 2020
iCollin
reviewed
Oct 29, 2020
src/components/application_manager/src/state_controller_impl.cc
Outdated
Show resolved
Hide resolved
iCollin
reviewed
Oct 29, 2020
.../application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/sdl_activate_app_request.cc
Show resolved
Hide resolved
iCollin
added a commit
that referenced
this pull request
Oct 29, 2020
* remove cloud app exception from StateControllerImpl::OnApplicationRegistered * Fix/ Postpone application activation if registration is not complete yet (#3557) * Postpone application activation if registration is not complete yet * fixup! Postpone application activation if registration is not complete yet * fixup! Postpone application activation if registration is not complete yet Co-authored-by: Andrii Kalinich <[email protected]> * fix style * fix unit tests Co-authored-by: Ira Lytvynenko (GitHub) <[email protected]> Co-authored-by: Andrii Kalinich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3549
This PR is [ready] for review.
Risk
This PR makes [no] API changes.
Testing Plan
Script from smartdevicelink/sdl_atf_test_scripts#2470
Summary
There was an issue when the SDL receives SDLActivateAppRequest from HMI and activates the app before the registration is completed and NONE HMI level is assigned. In this case, after the registration is complete SDL will assign NONE hmi level for the app that was in FULL so additional steps will be required to activate the application one more time.
To prevent such a situation additional check for app HMI level has been added during the app activation (SDLActivateAppRequest):
if the app HMI level is INVALID_ENUM - it means that the registration isn't complete yet - so we need to postpone the activation.
After the registration is completed and HMI level NONE is assigned - need to check if we have the postponed activation for the app and if yes - start the postponed activation.
CLA