Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application activation after resumption #3550

Conversation

ychernysheva
Copy link
Contributor

Fixes #3542 #3532
This PR is ready for review.

Risk

This PR makes no API changes.

Testing Plan

Covered by ATF test scripts

Summary

There is a case when media application acquires wrong HMI Level (NONE instead of FULL) during activation. Root cause of this issue is a true value of is_resuming flag for application, which in fact completed resumption process. Before this flag was set to false only for applications with failed resumption, so there is a need to assign it to false for all already resumed applications regardless of successfulness of resumption.

Also note, that after widget resumption SDL doesn't resend the OnSCU notification with updates for the widget to the mobile app (If HMI sends this notification after the resumption is finished). This is happening because we are checking the value of is_resuming_ flag, which now is true even if the application was resumed and it had widgets to resume. So root cause of wrong behavior of OnSCU notification is incorrect value of is_resuming_ flag after completed resumption.

Additionally tiny refactoring was performed for two methods of ResumeController class: RestoreAppHMIState and StartAppHmiStateResumption. Their return value was changed from bool to void, because in fact we don't need this values, and determination of this value makes logic of these methods more complicated than it may be. Mentioned methods are invoked only once inside of ResumeController class, that's why this changes cannot adversely affect another logic.

CLA

@ychernysheva
Copy link
Contributor Author

@theresalech This fix is ready for review.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants