Keep FULL for apps after conflict resolution #3538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AKalinich-Luxoft
requested review from
LitvinenkoIra,
Ypostolov and
ychernysheva
ychernysheva
approved these changes
Oct 13, 2020
LitvinenkoIra
approved these changes
Oct 13, 2020
Ypostolov
approved these changes
Oct 13, 2020
AKalinich-Luxoft
force-pushed
the
fix/fix_deactivation_to_background
branch
from
3e2b5d8 to
0a0287b
Compare
|
@AKalinich-Luxoft Sorry i dont think this fix fully addresses the issue. I ran these scripts over 100 times and saw 3 failures. I believe the fix I suggested here resolved the issue, I did not see those errors when running the test repeatedly: #3527 (comment) |
|
@AKalinich-Luxoft Sorry i believe the failures were a false alarm. Sorry for the confusion, approving |
Jack-Byrne
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3527
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Covered by ATF script
Summary
There was found an issue in state controller related to wrong transition of non-media applications (not streamable and not audible) from FULL to BACKGROUND in case of some events. To fix that issue, SDL should check first if non-media application is currently in FULL and another application is not in FULL. If so, non-media application should stay in FULL.
CLA