Re-order rai logic for plugins #3526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuxoftAKutsan
approved these changes
Oct 5, 2020
| @@ -558,6 +558,9 @@ class ApplicationManager { | |||
| const std::shared_ptr<smart_objects::SmartObject>& | |||
| request_for_registration) = 0; | |||
|
|
|||
| virtual void FinalizeAppRegistration(ApplicationSharedPtr application, | |||
There was a problem hiding this comment.
Would be nice to have doxygen description
| plugin.OnApplicationEvent(plugin_manager::kApplicationRegistered, | ||
| application); | ||
| }; | ||
| application_manager_.ApplyFunctorForEachPlugin(on_app_registered); |
There was a problem hiding this comment.
In this case it is important to remember that when the plugin received kApplicationRegistered event, the application is not finally registered. I would add this as a comment in the kApplicationRegistered enum
There was a problem hiding this comment.
Noting that this placement is the most important part of the change. This event needed to happen before an app was added to the applications accessor in the app manager.
1 task
jacobkeeler
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3172 #3162
This PR is Ready for review.
Risk
This PR makes no API changes.
Testing Plan
Send on vehicle data notification at same time app registers. Core should not crash.
Summary
Moves the call to add the newly registered app to the applications list later in the registration process. This ensures that an app has all of its necessary plugins added before it is accessible by the applications accessor.
CLA