Add check for already processed resumptions to ResumptionDataProcessor

[ychernysheva]

Fixes #3522

This PR is ready for review.

Risk

This PR makes no API changes.

Summary

This PR is intended to improve synchronization in ResumptionDataProcessorImpl::Restore() method. Root cause of this problem is a case when some requests from HMI may be processed earlier than callback will be set in ResumptionDataProcessor. So in this case execution of ProcessResumptionStatus method for such application will be aborted due to absence of callback, and this behavior is valid and expected. But after this variable is_requests_list_empty will be assigned to true, and there is a problem, because now Restore() method doesn't have any checks for actual result of already performed operation. That's why in all such cases, regardless of actual resumption status, callback will be called with parameters mobile_apis::Result::SUCCESS and "Data resumption successful".

That's why corresponding check is added to Restore method, also some refactoring is performed to avoid duplication of code, redundant check HasDataToRestore is deleted (now in fact it will be always true), and potential source of memory leak in EraseAppResumptionData method is fixed (before only last request was deleted from request_app_ids_ map).

In current environment this issue is hard to reproduce, but it may be a problem if this code is used in other environment or in other systems (for example, with proprietary hardware) without synchronization improvement.

CLA

• I have signed the CLA

[ychernysheva]

@theresalech This fix is ready for review.
Thank you!

[dboltovskyi]

Rebuild required