Fix/Delay OnHMIStatus until RAI response is sent #3506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Byrne
reviewed
Sep 17, 2020
| "Application " | ||
| << app->app_id() | ||
| << " not ready to receive OnHMIStatus. Delaying notification"); | ||
| pending_hmistatus_notification_apps_.insert(app->app_id()); |
There was a problem hiding this comment.
There should probably be a lock used around pending_hmistatus_notification_apps_ usage
Jack-Byrne
reviewed
Sep 17, 2020
| @@ -430,6 +431,7 @@ class StateControllerImpl : public event_engine::EventObserver, | |||
| typedef std::list<WindowStatePair> WindowStatePairs; | |||
| std::map<uint32_t, WindowStatePairs> postponed_app_widgets_; | |||
|
|
|||
| std::unordered_set<uint32_t> pending_hmistatus_notification_apps_; | |||
There was a problem hiding this comment.
Maybe rename to apps_with_pending_hmistatus_notification_
1 task
Jack-Byrne
approved these changes
Sep 21, 2020
ShobhitAd
deleted the
fix/delay_onhmistatus_until_rai_response_is_sent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3499
This PR is not ready for review.
Risk
This PR makes no API changes.
Testing Plan
Manual testing with Test Suite App
Tasks Remaining:
CLA