[SDL-0188] Interior Vehicle Data Resumption #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix RAI default timeout As RAI request does not depend on any HMI response there is no need to track any timeout for it. RAI request will be removed from/ RequestController queue upon RAI response which will be sent anyway Update UT
Update SDL logic to avoid sending of unsubscribeVD to HMI during vehicle data resumption for case when another application is also have pending subscription for the same vehicle data.
Changed SDL logic to update subscription results for each pending subscription request before notifying resumption processor about current subscription is processed. This should be done beforehand because after raising event to processor it can finish resumption process and if it has failed then it can trigger sending of the next subscription request. So at that point, each subscription request should contain updated subscriptions status, otherwise some redundant requests might be sent.
jacobkeeler
changed the base branch from
develop
to
feature/reference_sdl_0190_resumption_data_error_handling
jacobkeeler
requested changes
Sep 3, 2020
...tion_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/rc_pending_resumption_handler.h
Outdated
Show resolved
Hide resolved
...omponents/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_pending_resumption_handler.cc
Outdated
Show resolved
Hide resolved
...omponents/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_pending_resumption_handler.cc
Outdated
Show resolved
Hide resolved
...omponents/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_pending_resumption_handler.cc
Outdated
Show resolved
Hide resolved
...omponents/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_pending_resumption_handler.cc
Outdated
Show resolved
Hide resolved
src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_app_extension.cc
Outdated
Show resolved
Hide resolved
|
Please be informed, we have added one more additional commit 1cccc48, |
jacobkeeler
force-pushed
the
feature/reference_sdl_0190_resumption_data_error_handling
branch
from
2e48d88 to
1bda351
Compare
jacobkeeler
changed the base branch from
feature/reference_sdl_0190_resumption_data_error_handling
to
develop
jacobkeeler
changed the base branch from
develop
to
feature/reference_sdl_0190_resumption_data_error_handling
|
@jacobkeeler Regarding comment #3480 (comment) : |
…eature/sdl_0188_interior_vehicle_data_resumption
jacobkeeler
changed the base branch from
feature/reference_sdl_0190_resumption_data_error_handling
to
develop
jacobkeeler
reviewed
Sep 4, 2020
...mponents/application_manager/rpc_plugins/rc_rpc_plugin/include/rc_rpc_plugin/rc_rpc_plugin.h
Outdated
Show resolved
Hide resolved
|
@AKalinich-Luxoft I should be able to approve after conflicts are fixed with develop |
…_vehicle_data_resumption
@jacobkeeler resolved in b46d79e |
jacobkeeler
approved these changes
Sep 4, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2661
This PR is ready for review.
Summary
SDL-0188 Interior Vehicle Data Resumption feature implementation
Use API from smartdevicelink/rpc_spec#274
Testing Plan
ATF Tests from smartdevicelink/sdl_atf_test_scripts#2444
Dependencies:
!! Please note that this feature is based on the [SDL-0190] and this PR should be merged after #3475
Commits started from 6bd4011 contain [SDL-0188] implementation
CLA