[SDL 0046] Implement logger abstraction #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
LuxoftAKutsan
approved these changes
Aug 7, 2020
| LoggerImpl::LoggerImpl(bool use_message_loop_thread) | ||
| : impl_(nullptr), use_message_loop_thread_(use_message_loop_thread) { | ||
| if (!use_message_loop_thread_) | ||
| logger::logger_status = LogerThreadIsNotUsed; |
VladSemenyuk
force-pushed
the
feature/sdl_0046_logger_abstraction
branch
from
7ab7d47 to
5749f3d
Compare
3 tasks
|
@LuxoftAKutsan please mark as review ready. Currently this pr is marked as not ready for review. |
mrapitis
approved these changes
Aug 14, 2020
|
@theresalech Ford has approved of this PR. Thanks! |
ShobhitAd
requested changes
Aug 24, 2020
...onents/application_manager/rpc_plugins/rc_rpc_plugin/src/resource_allocation_manager_impl.cc
Outdated
Show resolved
Hide resolved
src/components/application_manager/include/application_manager/application_manager_impl.h
Outdated
Show resolved
Hide resolved
src/components/application_manager/include/application_manager/application_manager_impl.h
Outdated
Show resolved
Hide resolved
src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_helpers.cc
Outdated
Show resolved
Hide resolved
src/components/application_manager/rpc_plugins/rc_rpc_plugin/src/rc_helpers.cc
Outdated
Show resolved
Hide resolved
src/components/transport_manager/src/bluetooth/bluetooth_device_scanner.cc
Outdated
Show resolved
Hide resolved
|
@ShobhitAd All requested changes have been prepared. |
Create one logger instance for shared libraries
…rc/resource_allocation_manager_impl.cc Co-authored-by: Shobhit Adlakha <[email protected]>
VladSemenyuk
force-pushed
the
feature/sdl_0046_logger_abstraction
branch
from
54d19cf to
3ee8ad4
Compare
ShobhitAd
requested changes
Sep 1, 2020
ShobhitAd
approved these changes
Sep 1, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1480
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Summary
Implemented and integrated logger abstraction.
CLA