Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResetGlobalProperties doesn't reset HELPPROMPT and VRHELPITEMS to default values #3357

Merged
merged 3 commits into from
May 18, 2020

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented May 11, 2020

REUPLOAD #2337 (branch deleted)

Fixes #1306

Fix bug ResetGlobalProperties does't reset HELPPROMPT
and VRHELPITEMS to default values

Fix UT's after bugfixing

  • Fix ResetGlobalPropertiesRequestTest
  • Add mock function into MockApplicationManagerSettings

Github issue

Co-authored-by: v-malko4 [email protected]

UPDATES SINCE #2337

  • Change vr_help_title smart object type to string instead of map
  • Rename unit test variable SmartObject help_prompt_ to so_help_prompt as a variable help_prompt already exists and having two so similar is confusing.

Fix bug `ResetGlobalProperties` does't reset `HELPPROMPT`
and `VRHELPITEMS` to default values

Fix UT's after bugfixing

 - Fix `ResetGlobalPropertiesRequestTest`
 - Add mock function into `MockApplicationManagerSettings`

Github issue #1306

Co-authored-by: v-malko4 <[email protected]>
@iCollin iCollin changed the title Fix bug ResetGlobalProperties (#2337) ResetGlobalProperties doesn't reset HELPPROMPT and VRHELPITEMS to default values May 11, 2020
Copy link
Contributor

@ShobhitAd ShobhitAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Style check is failing. Please run ./tools/infrastructure/check_style.sh --fix again and push the changes

@iCollin iCollin merged commit 63e8380 into develop May 18, 2020
@iCollin iCollin deleted the fix/resetglobalprops_vrhelp branch May 18, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants