Sdl passenger mode without ut implementation #2792

LuxoftAKutsan · 2018-12-21T12:10:45Z

Contains implementation of feature #2134

Do not contains Unit tests for the feature

All scripts from Ford-Luxoft/sdl_atf_test_scripts#1 passed

Feature overview :

Add optional lockScreenDismissalEnabled parameter to OnDriverDistraction notification to mobile.
Add lockScreenDismissalEnabled parameter to Policy (module_meta table).

In case if lockScreenDismissalEnabled is not available in policy table, SDL should not add lockScreenDismissalEnabled parameter to OnDriverDistraction notification to mobile.

In case if lockScreenDismissalEnabled is available in policy table, SDL should add it to OnDriverDistraction notification to mobile.

In case if SDL received OnDriverDistraction with DriverDistractionState = DD_OFF, SDL should not add lockScreenDismissalEnabled to OnDriverDistraction notification to mobile.

LuxoftAKutsan · 2018-12-21T12:12:42Z

...on_manager/rpc_plugins/sdl_rpc_plugin/src/commands/hmi/on_driver_distraction_notification.cc

@@ -127,6 +127,14 @@ void OnDriverDistractionNotification::Run() {
  (*on_driver_distraction)[strings::msg_params][mobile_notification::state] =
      state;

+  auto lock_screen_dismissal = application_manager_.GetPolicyHandler().LockScreenDismissalEnabledState();


@LuxoftAKutsan can be const

LuxoftAKutsan · 2018-12-21T12:12:56Z

src/components/application_manager/src/application_manager_impl.cc

@@ -3387,6 +3387,14 @@ void ApplicationManagerImpl::SendDriverDistractionState(
      mobile_api::FunctionID::OnDriverDistractionID;
  (*on_driver_distraction)[strings::msg_params][mobile_notification::state] =
      driver_distraction_state();
+  auto lock_screen_dismissal = policy_handler_->LockScreenDismissalEnabledState();


@LuxoftAKutsan can be const

LuxoftAKutsan · 2018-12-21T12:13:43Z

src/components/application_manager/src/policies/policy_handler.cc

@@ -1600,6 +1600,11 @@ void PolicyHandler::OnSystemReady() {
  policy_manager_->OnSystemReady();
 }

+const utils::OptionalVal<bool> PolicyHandler::LockScreenDismissalEnabledState() const {
+  POLICY_LIB_CHECK(false);


@LuxoftAKutsan probably return empty Value if policy library not available

LuxoftAKutsan · 2018-12-21T12:15:06Z

src/components/interfaces/MOBILE_API.xml

@@ -6775,6 +6775,13 @@
        <param name="state" type="DriverDistractionState" mandatory="true">
            <description>Current State of Driver Distraction</description>
        </param>
+        <param name="lockScreenDismissalEnabled" type="Boolean" mandatory="false">
+            <description>


@LuxoftAKutsan formating of xml should be fixed

LuxoftAKutsan · 2018-12-21T12:15:39Z

src/components/policy/policy_external/include/policy/policy_manager_impl.h

@@ -148,6 +148,14 @@ class PolicyManagerImpl : public PolicyManager {
   */
  void KmsChanged(int kilometers) OVERRIDE;

+  /**


@LuxoftAKutsan avoid description in overridings of the functions

LuxoftAKutsan · 2018-12-21T12:17:37Z

src/components/policy/policy_external/src/cache_manager.cc

+  if (module_config.lock_screen_dismissal_enabled.is_initialized()) {
+    return utils::OptionalVal<bool>(*module_config.lock_screen_dismissal_enabled);
+  }
+  return utils::OptionalVal<bool>(utils::OptionalVal<bool>::EMPTY);


@LuxoftAKutsan would be better to create initial empty variable and return it in CACHE_MANAGER_CHECK and outside the if. If it is possible to use this variable inside of, wold be wonderful

LuxoftAKutsan · 2018-12-21T12:18:36Z

src/components/policy/policy_external/src/sql_pt_representation.cc

@@ -1267,6 +1270,17 @@ bool SQLPTRepresentation::SaveModuleConfig(
      : query.Bind(8);
  config.certificate.is_initialized() ? query.Bind(9, *(config.certificate))
                                      : query.Bind(9);
+  LOG4CXX_WARN(logger_,
+               "AKUTSAN isi ninted "


@LuxoftAKutsan remove debug log

LuxoftAKutsan · 2018-12-21T12:18:46Z

src/components/policy/policy_external/src/sql_pt_representation.cc

+                   << config.lock_screen_dismissal_enabled.is_initialized());
+
+  if (config.lock_screen_dismissal_enabled.is_initialized()) {
+    LOG4CXX_WARN(logger_, "AKUTSAN bind val");


@LuxoftAKutsan remove debug log

LuxoftAKutsan · 2018-12-21T12:18:50Z

src/components/policy/policy_external/src/sql_pt_representation.cc

+    LOG4CXX_WARN(logger_, "AKUTSAN bind val");
+    query.Bind(10, *(config.lock_screen_dismissal_enabled));
+  } else {
+    LOG4CXX_WARN(logger_, "AKUTSAN bind null");


@LuxoftAKutsan remove debug log

LuxoftAKutsan · 2018-12-21T12:19:03Z

src/components/policy/policy_regular/include/policy/cache_manager.h

@@ -41,6 +41,7 @@
 #include "utils/threads/thread.h"
 #include "utils/threads/thread_delegate.h"

+


@LuxoftAKutsan redundant emptyline

LuxoftAKutsan added 7 commits December 17, 2018 17:48

Make optional type keep data by value

1bab103

Add lock_screen_dismissal_enabled to API and policy

8c8eb4d

Add lock_screen_dismissal_enabled to Policy databse

7765f99

Add lock_screen_dismissal_enabled to Policy Interface

ef78088

Process lock_screen_dismissal_enabled logic

ec1d72e

Fix unit tests

aee9763

fixup! Add lock_screen_dismissal_enabled to Policy databse

6750780

LuxoftAKutsan commented Dec 21, 2018

View reviewed changes

LuxoftAKutsan requested a review from AByzhynar December 21, 2018 12:27

LuxoftAKutsan closed this Dec 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sdl passenger mode without ut implementation #2792

Sdl passenger mode without ut implementation #2792

LuxoftAKutsan commented Dec 21, 2018 •

edited

Loading

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

LuxoftAKutsan Dec 21, 2018

		@@ -41,6 +41,7 @@
		#include "utils/threads/thread.h"
		#include "utils/threads/thread_delegate.h"

Sdl passenger mode without ut implementation #2792

Sdl passenger mode without ut implementation #2792

Conversation

LuxoftAKutsan commented Dec 21, 2018 • edited Loading

Feature overview :

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LuxoftAKutsan commented Dec 21, 2018 •

edited

Loading