feature/media skip indicators #2703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR contains major changes in MIBILE_API and HMI_API. Competitive systems have the ability to show time skip buttons for podcast and audio book media that desire them. These kinds of buttons reduce confusion with the driver by showing them what will be happening when they skip forward and back. Current systems can only show a skip track button, which works for music, but less so for podcasts and audio books. Added a new type SeekIndicatorType, that can be in two states: TRACK or TIME. Added a new type SeekStreamingIndicator, that contains SeekIndicatorType. If SeekIndicatorType exists in TIME state, it has to contains 'seekTime' parameter with count of time to seek audio stream. Added new parameters to SetMediaClockTimer request: forwardSeekIndicator and backSeekIndicator as SeekStreamingIndicator type.
IGapchuk
changed the base branch from
master
to
feature/media_skip_indicators
IGapchuk
requested review from
AByzhynar,
AKalinich-Luxoft,
APipko,
BSolonenko,
Itileda,
LuxoftAKutsan,
mked-luxoft,
a user,
Ypostolov and
ZhdanovP
APipko
approved these changes
Oct 22, 2018
| MessageSharedPtr msg = CreateMsgParams(); | ||
| mobile_apis::SeekIndicatorType::eType seek_indicator_type = | ||
| mobile_apis::SeekIndicatorType::TIME; | ||
| std::uint32_t seek_time = 10; |
There was a problem hiding this comment.
For magic numbers it's better to use const. And please use u postfix to avoid implicit conversion
| static_cast<mobile_apis::SeekIndicatorType::eType>( | ||
| (*msg)[am::strings::msg_params][am::strings::forward_seek_indicator] | ||
| .asInt())); | ||
| auto msg_params = (*msg)[am::strings::msg_params]; |
There was a problem hiding this comment.
Maybe it's better to move this line before first usage of (*msg)[am::strings::msg_params]
| EXPECT_EQ( | ||
| seek_indicator_type, | ||
| static_cast<mobile_apis::SeekIndicatorType::eType>( | ||
| (*msg)[am::strings::msg_params][am::strings::forward_seek_indicator] |
There was a problem hiding this comment.
Please, check the existing of key (using assert) before this expectation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2625
This PR is ready for review.
Risk
This PR makes major API changes.
Testing Plan
Covered by Unit tests.
Summary
Competitive systems have the ability to show time skip buttons for podcast and audio book media that desire them. These kinds of buttons reduce confusion with the driver by showing them what will be happening when they skip forward and back. Current systems can only show a skip track button, which works for music, but less so for podcasts and audio books.
Added a new type SeekIndicatorType, that can be in two states: TRACK or TIME.
Added a new type SeekStreamingIndicator, that contains SeekIndicatorType. If SeekIndicatorType exists in TIME state, it has to contains 'seekTime' parameter with count of time to seek audio stream.
Added new parameters to SetMediaClockTimer request: forwardSeekIndicator and backSeekIndicator as SeekStreamingIndicator type.
Tasks Remaining:
CLA