[SDL4.0]SDL does not create icons folder in case it was removed #2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for existence directory of app icons folder has been added to SetAppIconRequest.
ghost
requested review from
AKalinich-Luxoft,
AByzhynar,
LuxoftAKutsan,
BSolonenko,
ZhdanovP,
mked-luxoft,
IGapchuk and
mkorniichuk
mked-luxoft
reviewed
Oct 2, 2018
| @@ -60,6 +60,14 @@ SetAppIconRequest::SetAppIconRequest( | |||
| , is_icons_saving_enabled_(false) { | |||
| const std::string path = | |||
| application_manager_.get_settings().app_icons_folder(); | |||
|
|
|||
| if (!file_system::DirectoryExists(path)) { | |||
| LOG4CXX_WARN(logger_, "App icons folder doesn't exist."); | |||
There was a problem hiding this comment.
@ValeriiMalkov as a suggestion, maybe it's worth to log the unexisting path here too
There was a problem hiding this comment.
@mked-luxoft what purpose for this? See next lines, please
AKalinich-Luxoft
approved these changes
Oct 2, 2018
|
@ValeriiMalkov Check grammar in PR description |
KVGrygoriev
approved these changes
Oct 9, 2018
LuxoftAKutsan
approved these changes
Oct 9, 2018
AByzhynar
approved these changes
Oct 11, 2018
BSolonenko
approved these changes
Oct 16, 2018
ZhdanovP
approved these changes
Oct 16, 2018
IGapchuk
approved these changes
Nov 5, 2018
mkorniichuk
approved these changes
Nov 29, 2018
1 task
iCollin
added a commit
that referenced
this pull request
May 11, 2020
… (#3359) The check for existence directory of app icons folder has been added to SetAppIconRequest. Co-authored-by: ValeriiMalkov <[email protected]> Co-authored-by: ValeriiMalkov <[email protected]>
ydementieiev
pushed a commit
to LuxoftSDL/sdl_core
that referenced
this pull request
May 18, 2020
…tdevicelink#2649) (smartdevicelink#3359) The check for existence directory of app icons folder has been added to SetAppIconRequest. Co-authored-by: ValeriiMalkov <[email protected]> Co-authored-by: ValeriiMalkov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1003
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Covered by ATF test
Summary
There was a problem if SDL4.0 feature is enabled in
.inifile. ' Icons' values is set asAppIconsFoldervalue. If remove this folder after start SDL and register app with 4th protocolSDL should creates this folder.
CLA