Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDL retry send StartStream/StartAudioStream one time less #2210

Closed
wants to merge 1 commit into from
Closed

Fix SDL retry send StartStream/StartAudioStream one time less #2210

wants to merge 1 commit into from

Conversation

mkloouo
Copy link

@mkloouo mkloouo commented May 23, 2018

Fixes #960
This PR is ready for review.

Risk

This PR makes no API changes.

Summary

This PR fixes retry number check for HMI Commands StartStream/StartAudioStream.

Testing Plan

Tested on Ubuntu 16.04. Successful ATF test pass.

Changelog

Breaking Changes
  • None.
Enhancements
  • None.
Bug Fixes

CLA

SDL retry one time less because of wrong check
Fixed by change in logic
@mkloouo mkloouo changed the base branch from master to develop May 23, 2018 10:53
@KVGrygoriev KVGrygoriev self-requested a review May 23, 2018 12:22
@KVGrygoriev KVGrygoriev requested a review from AByzhynar May 23, 2018 14:36
@JenkinsSDLOnCloud
Copy link

Can one of the admins verify this patch?

@jacobkeeler
Copy link
Contributor

Unable to resolve merge conflicts since the original repository was deleted, will submit this fix separately

@jacobkeeler jacobkeeler mentioned this pull request Aug 29, 2018
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants