Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDL version info in BasicCommunication.GetSystemInfo Response #9

Closed
henry-fan opened this issue Dec 15, 2014 · 10 comments
Closed
Milestone

Comments

@henry-fan
Copy link

Head unit wants to show SDL version in system diagnosis. Suggest we add SDL version in HMI protocol GetSystemInfo.

@justinjdickow
Copy link
Contributor

What type do you think system version should be?

@henry-fan
Copy link
Author

Something like "SDL_RB_B3.6_{build number}", I can see a CCPU version left blank in system info response. Is it intended to indicate the SDL version?

@justinjdickow
Copy link
Contributor

Oops, I didn't realize this was already an issue. I would suggest we also add a new field alongside syncMsgVersion so we can eventually deprecate that field which will indicate the version in the register app interface response.

@justinjdickow
Copy link
Contributor

Some feedback on this issue I got via email

There is a constant string(kApplicationVersion) to define the SDL Core version but isn’t exposed to HMI protocol.
unnamed
Considering there are variants HMI implementations near future, that should be an enhancement

@justinjdickow
Copy link
Contributor

We added sdl version and system software version to register app interface response to communicate this information. It sounds like the proposal is to also add this information to be sent to the HMI.

@justinjdickow
Copy link
Contributor

@henry-fan Can you let us know if that information in the register app interface being communicated to the application is enough for your system diagnosis purposes or whether it needs to be on the hmi?

@justinjdickow justinjdickow added this to the 4.1.0 milestone Aug 28, 2015
@henry-fan
Copy link
Author

@justinjdickow
we need SDL version string to be exposed to HMI. Thanks.

AGaliuzov added a commit that referenced this issue Oct 20, 2015
@justinjdickow
Copy link
Contributor

@henry-fan Do you know if this was ever resolved?

@BrandonHe
Copy link
Contributor

@justinjdickow
As far as we know, neither sdl_version nor kApplicationVersion exposed to HMI. Thanks.

dev-gh pushed a commit to dev-gh/sdl_core that referenced this issue Apr 22, 2016
dev-gh pushed a commit to dev-gh/sdl_core that referenced this issue Jun 7, 2016
Media manager build fixed
Related-issues: APPLINK-22713, APPLINK-22716
LuxoftAKutsan pushed a commit that referenced this issue Feb 23, 2017
REVSDL-881: fix on RSDL's side: close client's port.
@Jack-Byrne
Copy link
Collaborator

@henry-fan I think this is partly covered by https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0096-deliver-build-configuration.md

If this solution does not satisfy your needs please consider submitting a proposal to the sdl evolution repository.

https://github.com/smartdevicelink/sdl_evolution

mked-luxoft referenced this issue in mked-luxoft/sdl_core Oct 8, 2018
…in_request_SubscribeButton

Missed mandatory parameter `appID` in request SubscribeButton was added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants