Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL sends params from new assigned group for app in userDisallowed section of onPermissionChange in proprietary flow #2961

Closed
GetmanetsIrina opened this issue Jul 8, 2019 · 1 comment
Closed

SDL sends params from new assigned group for app in userDisallowed section of onPermissionChange in proprietary flow #2961

GetmanetsIrina opened this issue Jul 8, 2019 · 1 comment
Labels
Bug

Comments

@GetmanetsIrina
Copy link

GetmanetsIrina commented Jul 8, 2019 •
edited
Loading

Bug Report

SDL sends params from new assigned group for app in userDisallowed section of onPermissionChange in proprietary flow

Reproduction Steps
  1. SDL is built with PROPRIETARY policy flow
  2. App is registered and activated
Reproduction Steps
  1. PTU is performed with new assigned group which contains the list of parameters in parameters section
Expected Behavior

During PTU SDL sends OnPermissionChange notification with parameters from new assigned group for appropriate RPC in allowed section

Observed Behavior

SDL sends parameters in userDisallowed section

{"parameterPermissions":{"userDisallowed":["gps","speed"],"allowed":["airbagStatus","clusterModeStatus","eCallInfo","emergencyEvent"]},"hmiPermissions":{"userDisallowed":["BACKGROUND","FULL","LIMITED"],"allowed":[]},"rpcName":"GetVehicleData"}
OS & Version Information
Logs

SDLlogs.tar.gz
@GetmanetsIrina GetmanetsIrina changed the title SDL sends params from new functional group in userDisallowed section in proprietary flow SDL sends params from new functional group in userDisallowed section of onPermissionChange in proprietary flow Jul 8, 2019
@GetmanetsIrina GetmanetsIrina changed the title SDL sends params from new functional group in userDisallowed section of onPermissionChange in proprietary flow SDL sends params from new assigned group for app in userDisallowed section of onPermissionChange Jul 8, 2019
@GetmanetsIrina GetmanetsIrina changed the title SDL sends params from new assigned group for app in userDisallowed section of onPermissionChange SDL sends params from new assigned group for app in userDisallowed section of onPermissionChange in proprietary flow Jul 8, 2019
MNikora pushed a commit that referenced this issue Jul 29, 2019
@mkorniichuk @LuxoftAKutsan
Fix OnPermissionChangeNotif data corruption
fb05634 
Fixes : #2961
* if group is revoked from app, it was not noticed if user consent required,
which is not valid for proprietary policy flow
*  OnPermissionChange notification is now sent after application of PTU
LuxoftAKutsan pushed a commit that referenced this issue Jul 29, 2019
@mkorniichuk @LuxoftAKutsan
Fix OnPermissionChangeNotif data corruption
6284029 
Fixes : #2961
* if group is revoked from app, it was not noticed if user consent required,
which is not valid for proprietary policy flow
*  OnPermissionChange notification is now sent after application of PTU

Replace ModuleConfig with Whole PT
LuxoftAKutsan pushed a commit that referenced this issue Jul 29, 2019
@mkorniichuk @LuxoftAKutsan
Fix OnPermissionChangeNotif data corruption
4d1e08f 
Fixes : #2961

fix sending OnPermissionChanged after PTU with removing functional
group. OnPermissionChange notification is now sent after applying PTU

Replace ModuleConfig with Whole PT
@LuxoftAKutsan LuxoftAKutsan mentioned this issue Jul 29, 2019
Merged
1 task
mkorniichuk added a commit that referenced this issue Aug 1, 2019
@mkorniichuk
Fix OnPermissionChangeNotif data corruption
8c1f7d6 
Fixes : #2961

fix sending OnPermissionChanged after PTU with removing functional
group. OnPermissionChange notification is now sent after applying PTU

Replace ModuleConfig with Whole PT
dboltovskyi pushed a commit to dboltovskyi/sdl_core that referenced this issue Aug 29, 2019
@mkorniichuk @LuxoftAKutsan
Fix OnPermissionChangeNotif data corruption
47cfef3 
Fixes : smartdevicelink#2961

fix sending OnPermissionChanged after PTU with removing functional
group. OnPermissionChange notification is now sent after applying PTU

Replace ModuleConfig with Whole PT
GetmanetsIrina pushed a commit to GetmanetsIrina/sdl_core that referenced this issue Aug 30, 2019
@mkorniichuk
Fix OnPermissionChangeNotif data corruption
e284c1e 
Fixes : smartdevicelink#2961

fix sending OnPermissionChanged after PTU with removing functional
group. OnPermissionChange notification is now sent after applying PTU

Replace ModuleConfig with Whole PT
mkorniichuk added a commit that referenced this issue Aug 30, 2019
@mkorniichuk
Fix OnPermissionChangeNotif data corruption
7e5719c 
Fixes : #2961

fix sending OnPermissionChanged after PTU with removing functional
group. OnPermissionChange notification is now sent after applying PTU

Replace ModuleConfig with Whole PT
@jacobkeeler
Copy link
Contributor

Confirmed non-reproducible on develop, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jacobkeeler @GetmanetsIrina