-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle bad/corrupt data #1
Comments
Perhaps we add a little bit of color. The issue is how should Core handle bad data coming from the phone. The three options above each have a list of pros and cons when dealing with apps/phones that send erroneous data. Today, I believe the behavior is to disconnect. There are likely a host of better options which are proposed, but mainly, the two further options are a lot more graceful. Did we want to elaborate the problem and the options here? |
Bringing in a comment from Jacob Rau to test our bot.
|
Application manager merge from WIN SDL Related-issues: APPLINK-22713, APPLINK-22716
Libusb build setup Related-issues: APPLINK-22713, APPLINK-22716
* Fix problems according to test coverage Related-tesk: [APPLINK-25171](https://adc.luxoft.com/jira/browse/APPLINK-25171)
…ster * commit '500547ec4492f4681e56bf98dae104581136a216': REVSDL-632: fix code review issues REVSDL-632: added documentation to can connection base class. REVSDL-632: adjusted test REVSDL-632: part of test REVSDL-632: fix subscribtion on messages from can REVSDL-632: can connection interface changed.
…_master to develop * commit '5555b6440d9b9803a5c820a8502a53791e29ead9': (37 commits) Fixed improper variable name Simplified return Fixed style issues Fix Travis build error Changing switch to map access Fixed casting issues, included DCHECK for unrecognized AppHMIType Fixes issue where the list of AppHMITypes sent from mobile was being incorrectly compared to the allowed AppHMITypes in the policy table Changed ParsePTString() to return the calculated content length Change policy url to public smartdevicelink policy url Fix "Content-Length" Spelling and Calculation ParsePTString to Modify string, instead of returning a copy Update README.md Parse PT String for HTTP Request Body updating as per review comments fix for pthread_join() crash in some platforms Reverts device certificate support. Fixes policy update triggering on exceedeed kilometers. Fixes policy update triggering on application registration Removes non-open-source fields support from policy Fixes retry sequence implementation ...
…nterface_listener_design Use Pimple idiom for Network Interface Listener
So far here are our proposed solutions on core:
-Disconnect on bad packet
-Drop packets/RPCs silently when stuff goes south
-Full retry strategy
The text was updated successfully, but these errors were encountered: