Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle bad/corrupt data #1

Closed
joeygrover opened this issue Oct 9, 2014 · 2 comments
Closed

How to handle bad/corrupt data #1

joeygrover opened this issue Oct 9, 2014 · 2 comments
Assignees
Labels

Comments

@joeygrover
Copy link
Member

So far here are our proposed solutions on core:

-Disconnect on bad packet
-Drop packets/RPCs silently when stuff goes south
-Full retry strategy

@jmarchwi-ford
Copy link

Perhaps we add a little bit of color.

The issue is how should Core handle bad data coming from the phone. The three options above each have a list of pros and cons when dealing with apps/phones that send erroneous data. Today, I believe the behavior is to disconnect.

There are likely a host of better options which are proposed, but mainly, the two further options are a lot more graceful. Did we want to elaborate the problem and the options here?

@justinjdickow
Copy link
Contributor

Bringing in a comment from Jacob Rau to test our bot.

If we allow RPCs to be dropped, we will need to advise our developers that they need to be aware of RPCs which they send to which do not receive a response, when it matters that the RPC run successfully. If we are to keep the quality of approved apps up, we should include in our validation a test which rejects/doesn't respond to some RPCs, to ensure the app does retry, at least to ones like CreateInteractionChoiceSet.

@justinjdickow justinjdickow self-assigned this Feb 13, 2015
dev-gh referenced this issue in dev-gh/sdl_core Apr 12, 2016
Application manager merge from WIN SDL
anosach-luxoft added a commit that referenced this issue Jun 8, 2016
Application manager merge from WIN SDL
Related-issues: APPLINK-22713, APPLINK-22716
anosach-luxoft pushed a commit that referenced this issue Jun 8, 2016
Libusb build setup
Related-issues: APPLINK-22713, APPLINK-22716
anosach-luxoft pushed a commit that referenced this issue Oct 11, 2016
* Fix problems according to test coverage

Related-tesk: [APPLINK-25171](https://adc.luxoft.com/jira/browse/APPLINK-25171)
dcherniev pushed a commit to dcherniev/sdl_core that referenced this issue Feb 6, 2017
LuxoftAKutsan pushed a commit that referenced this issue Feb 23, 2017
…ster

* commit '500547ec4492f4681e56bf98dae104581136a216':
  REVSDL-632: fix code review issues
  REVSDL-632: added documentation to can connection base class.
  REVSDL-632: adjusted test
  REVSDL-632: part of test
  REVSDL-632: fix subscribtion on messages from can
  REVSDL-632: can connection interface changed.
LuxoftAKutsan pushed a commit that referenced this issue Feb 23, 2017
davidswi pushed a commit to davidswi/sdl_core that referenced this issue Oct 25, 2017
…_master to develop

* commit '5555b6440d9b9803a5c820a8502a53791e29ead9': (37 commits)
  Fixed improper variable name
  Simplified return
  Fixed style issues
  Fix Travis build error
  Changing switch to map access
  Fixed casting issues, included DCHECK for unrecognized AppHMIType
  Fixes issue where the list of AppHMITypes sent from mobile was being incorrectly compared to the allowed AppHMITypes in the policy table
  Changed ParsePTString() to return the calculated content length
  Change policy url to public smartdevicelink policy url
  Fix "Content-Length" Spelling and Calculation
  ParsePTString to Modify string, instead of returning a copy
  Update README.md
  Parse PT String for HTTP Request Body
  updating as per review comments
  fix for pthread_join() crash in some platforms
  Reverts device certificate support.
  Fixes policy update triggering on exceedeed kilometers.
  Fixes policy update triggering on application registration
  Removes non-open-source fields support from policy
  Fixes retry sequence implementation
  ...
jacobkeeler pushed a commit that referenced this issue Jul 6, 2018
…nterface_listener_design

Use Pimple idiom for Network Interface Listener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants