Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default input mask to resetGlobalProperties test #2526

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

Jack-Byrne
Copy link
Collaborator

This PR is ready for review.

Summary

Add change needed for core pr 3635

CLA

@Jack-Byrne Jack-Byrne changed the title Add default input mask to resetGlobalProperties Add default input mask to resetGlobalProperties test Feb 18, 2021
@dboltovskyi
Copy link
Contributor

@JackLivio Please notice script may fail still (~80%) with message:

 HMI call UI.SetGlobalProperties: ValidIf: 
Parameter keyboardProperties.maskInputCharacters: got string, expected KeyboardInputMask

The reason of that is strict validation against API which is enabled by default in ATF by config.ValidateSchema parameter:
https://github.com/smartdevicelink/sdl_atf/blob/develop/modules/configuration/base_config.lua#L52

So the issue actually in core in HMI_API:
https://github.com/smartdevicelink/sdl_core/blob/develop/src/components/interfaces/HMI_API.xml#L3224

Existing type="KeyboardInputMask" needs to be corrected to type="Common.KeyboardInputMask" since KeyboardInputMask is defined in Common interface

@Jack-Byrne
Copy link
Collaborator Author

@Jack-Byrne Jack-Byrne merged commit 4cba03c into develop Feb 26, 2021
@Jack-Byrne Jack-Byrne deleted the fix/autocomplete_list_failure_input_mask branch February 26, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants