Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for handling OnWayPointChange from mobile #2486

Merged
merged 4 commits into from
Dec 9, 2020

Conversation

jacobkeeler
Copy link
Contributor

ATF Test Scripts to check smartdevicelink/sdl_core#3573

This PR is ready for review.

Summary

Add tests for OnWayPointChange passthrough with app services

ATF version

develop

Changelog

Enhancements
  • Add tests regarding waypoint handling for NAVIGATION app services

CLA

@jacobkeeler jacobkeeler changed the title Fix/on way point change from mobile Handle OnWayPointChange from mobile Nov 20, 2020
@jacobkeeler jacobkeeler changed the title Handle OnWayPointChange from mobile Add tests for handling OnWayPointChange from mobile Nov 20, 2020
@Jack-Byrne
Copy link
Collaborator

Jack-Byrne commented Nov 24, 2020

Not sure if i should comment here or on the Core pr, but there are several failures and aborted tests in the AppService directory

Test target: test_scripts/AppServices
----------------------------------------------------------------------------------------------------
01:	PASSED	test_scripts/AppServices/AppServiceActivation/001_mobile_deactivate_success.lua
02:	ABORTED	test_scripts/AppServices/AppServiceActivation/002_hmi_deactivate_success.lua
03:	ABORTED	test_scripts/AppServices/AppServiceActivation/003_two_apps_activate_success.lua
04:	ABORTED	test_scripts/AppServices/AppServiceActivation/004_two_apps_default_disconnect_reconnect.lua
05:	PASSED	test_scripts/AppServices/GetAppServiceData/001_M2M_success_flow.lua
06:	ABORTED	test_scripts/AppServices/GetAppServiceData/002_M2H_success_flow.lua
07:	PASSED	test_scripts/AppServices/GetAppServiceData/003_H2M_success_flow.lua
08:	PASSED	test_scripts/AppServices/GetAppServiceData/004_M2M_unknown_param_success.lua
09:	PASSED	test_scripts/AppServices/GetAppServiceData/005_M2M_Nav_success_flow.lua
10:	PASSED	test_scripts/AppServices/GetAppServiceData/006_M2M_Weather_success_flow.lua
11:	PASSED	test_scripts/AppServices/GetAppServiceData/007_M2M_Future_service_type_success_flow.lua
12:	PASSED	test_scripts/AppServices/GetAppServiceData/008_M2M_Timeout.lua
13:	ABORTED	test_scripts/AppServices/GetAppServiceData/009_M2H_Timeout.lua
14:	PASSED	test_scripts/AppServices/GetAppServiceData/010_H2M_Timeout.lua
15:	PASSED	test_scripts/AppServices/GetAppServiceData/011_M2M_GENERIC_ERROR.lua
16:	ABORTED	test_scripts/AppServices/GetAppServiceData/012_M2H_GENERIC_ERROR.lua
17:	PASSED	test_scripts/AppServices/GetAppServiceData/013_H2M_GENERIC_ERROR.lua
18:	PASSED	test_scripts/AppServices/GetAppServiceData/014_M2M_Unknown_ServiceType.lua
19:	ABORTED	test_scripts/AppServices/GetAppServiceData/015_M2H_Unknown_ServiceType.lua
20:	PASSED	test_scripts/AppServices/GetAppServiceData/016_H2M_Unknown_ServiceType.lua
21:	PASSED	test_scripts/AppServices/GetAppServiceData/017_H2M_MediaImage_success.lua
22:	PASSED	test_scripts/AppServices/GetAppServiceRecords/001_GetAppServiceRecords_MOBILE.lua
23:	ABORTED	test_scripts/AppServices/GetAppServiceRecords/002_GetAppServiceRecords_HMI.lua
24:	ABORTED	test_scripts/AppServices/GetAppServiceRecords/003_GetAppServiceRecords_Multiple.lua
25:	PASSED	test_scripts/AppServices/GetFile/001_GetFile_Success.lua
26:	PASSED	test_scripts/AppServices/GetFile/002_GetFile_FileNotFound.lua
27:	FAILED	test_scripts/AppServices/GetFile/003_GetFile_Mobile_ASP.lua
28:	ABORTED	test_scripts/AppServices/GetFile/004_GetFile_HMI_ASP.lua
29:	ABORTED	test_scripts/AppServices/GetFile/005_GetFile_Timeout_HMI_ASP.lua
30:	PASSED	test_scripts/AppServices/OnAppServiceData/001_M2M_success_flow.lua
31:	ABORTED	test_scripts/AppServices/OnAppServiceData/002_M2H_success_flow.lua
32:	PASSED	test_scripts/AppServices/OnAppServiceData/003_H2M_success_flow.lua
33:	PASSED	test_scripts/AppServices/OnAppServiceData/004_OnAppServiceData_unknown_param_success.lua
34:	PASSED	test_scripts/AppServices/OnAppServiceData/005_M2M_Nav_success_flow.lua
35:	PASSED	test_scripts/AppServices/OnAppServiceData/006_M2M_Weather_success_flow.lua
36:	PASSED	test_scripts/AppServices/OnAppServiceData/007_M2M_Future_service_type_success_flow.lua
37:	ABORTED	test_scripts/AppServices/OnAppServiceData/008_M2M_service_not_active_flow.lua
38:	ABORTED	test_scripts/AppServices/OnAppServiceData/009_M2M_service_not_published_flow.lua
39:	FAILED	test_scripts/AppServices/OnAppServiceData/010_M2M_invalid_service_id_flow.lua
40:	ABORTED	test_scripts/AppServices/OnAppServiceData/011_M2M_service_type_mismatch_flow.lua
41:	PASSED	test_scripts/AppServices/OnAppServiceData/012_H2M_media_image_success.lua
42:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/001_M2M_success_flow.lua
43:	ABORTED	test_scripts/AppServices/PerformAppServiceInteraction/002_M2H_success_flow.lua
44:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/003_H2M_success_flow.lua
45:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/004_M2M_unknown_parameter_success.lua
46:	ABORTED	test_scripts/AppServices/PerformAppServiceInteraction/005_Mobile_requestServiceActive_background_success_flow.lua
47:	ABORTED	test_scripts/AppServices/PerformAppServiceInteraction/006_Mobile_requestServiceActive_foreground_success_flow.lua
48:	ABORTED	test_scripts/AppServices/PerformAppServiceInteraction/007_HMI_requestServiceActive_success_flow.lua
49:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/008_M2M_Timeout.lua
50:	ABORTED	test_scripts/AppServices/PerformAppServiceInteraction/009_M2H_Timeout.lua
51:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/010_H2M_Timeout.lua
52:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/011_M2M_GENERIC_ERROR.lua
53:	ABORTED	test_scripts/AppServices/PerformAppServiceInteraction/012_M2H_GENERIC_ERROR.lua
54:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/013_H2M_GENERIC_ERROR.lua
55:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/014_M2M_Unknown_ServiceId.lua
56:	ABORTED	test_scripts/AppServices/PerformAppServiceInteraction/015_M2H_Unknown_ServiceId.lua
57:	PASSED	test_scripts/AppServices/PerformAppServiceInteraction/016_H2M_Unknown_ServiceId.lua
58:	PASSED	test_scripts/AppServices/PublishAppService/001_Mobile_success_flow.lua
59:	PASSED	test_scripts/AppServices/PublishAppService/002_HMI_success_flow.lua
60:	PASSED	test_scripts/AppServices/PublishAppService/003_Nav_success_flow.lua
61:	PASSED	test_scripts/AppServices/PublishAppService/004_Weather_success_flow.lua
62:	PASSED	test_scripts/AppServices/PublishAppService/005_Future_service_type_success_flow.lua
63:	PASSED	test_scripts/AppServices/PublishAppService/006_Mobile_disallowed_flow.lua
64:	PASSED	test_scripts/AppServices/PublishAppService/007_Mobile_unknown_param_success.lua
65:	PASSED	test_scripts/AppServices/PublishAppService/008_Mobile_update_service_success.lua
66:	FAILED	test_scripts/AppServices/PublishAppService/009_Mobile_duplicate_name_rejected.lua
67:	ABORTED	test_scripts/AppServices/PublishAppService/010_HMI_update_service_success.lua
68:	ABORTED	test_scripts/AppServices/Resumption/001_Resumption_GetAppServiceData_Unexpected_Disconnect.lua
69:	FAILED	test_scripts/AppServices/RPCPassThrough/001_SendLocation_Handled_Request.lua
70:	FAILED	test_scripts/AppServices/RPCPassThrough/002_SendLocation_Unsupported_Request.lua
71:	FAILED	test_scripts/AppServices/RPCPassThrough/003_SendLocation_Request_Timeout.lua
72:	FAILED	test_scripts/AppServices/RPCPassThrough/004_SendLocation_MultipleAS.lua
73:	FAILED	test_scripts/AppServices/RPCPassThrough/005_SendLocation_Invalid_Permissions.lua
74:	FAILED	test_scripts/AppServices/RPCPassThrough/006_ButtonPress_Handled_Request.lua
75:	FAILED	test_scripts/AppServices/RPCPassThrough/007_ButtonPress_Invalid_Permissions.lua
76:	PASSED	test_scripts/AppServices/RPCPassThrough/008_PTU_allow_unknown_rpc_passthrough.lua
77:	FAILED	test_scripts/AppServices/RPCPassThrough/009_UnknownRPC_Consumer_UNSUPPORTED_REQUEST_policy_allow_flag_false.lua
78:	FAILED	test_scripts/AppServices/RPCPassThrough/010_UnknownRpc_Handled_Request.lua
79:	FAILED	test_scripts/AppServices/RPCPassThrough/011_UnknownRpc_Unsupported_Request.lua
80:	FAILED	test_scripts/AppServices/RPCPassThrough/012_UnknownRpc_Request_Timeout.lua
81:	FAILED	test_scripts/AppServices/RPCPassThrough/013_UnknownRpc_MultipleAS.lua
82:	PASSED	test_scripts/AppServices/RPCPassThrough/WayPoints/001_GetWayPoints_Handled_Request.lua
83:	PASSED	test_scripts/AppServices/RPCPassThrough/WayPoints/002_WayPointsSubscription_App_Provider.lua
84:	PASSED	test_scripts/AppServices/RPCPassThrough/WayPoints/003_WayPointsSubscription_Not_Supported_by_HMI.lua
85:	PASSED	test_scripts/AppServices/RPCPassThrough/WayPoints/004_WayPointsSubscription_Not_Handled_Request.lua
86:	PASSED	test_scripts/AppServices/RPCPassThrough/WayPoints/005_WayPointsSubscription_Service_Unpublished_While_Subscribed.lua
87:	PASSED	test_scripts/AppServices/RPCPassThrough/WayPoints/006_WayPointsSubscription_Service_Deactivated_While_Subscribed.lua
88:	PASSED	test_scripts/AppServices/RPCPassThrough/WayPoints/007_WayPointsSubscription_HMI_Error.lua
89:	PASSED	test_scripts/AppServices/SystemCapabilities/001_GetSystemCapability_success.lua
90:	PASSED	test_scripts/AppServices/SystemCapabilities/002_GetSystemCapabilitySubscribe_OnSystemCapability_on_unregister.lua
91:	PASSED	test_scripts/AppServices/SystemCapabilities/003_OnSystemCapability_on_deactivate_service.lua
92:	PASSED	test_scripts/AppServices/SystemCapabilities/004_GetSystemCapability_unsubscribe.lua
93:	PASSED	test_scripts/AppServices/SystemCapabilities/005_OnSystemCapability_unknown_parameter_success.lua
94:	PASSED	test_scripts/AppServices/UnpublishAppService/001_Mobile_success_flow.lua
95:	ABORTED	test_scripts/AppServices/UnpublishAppService/002_HMI_success_flow.lua
96:	PASSED	test_scripts/AppServices/UnpublishAppService/003_Mobile_failure_did_not_publish_requested_service.lua

@jacobkeeler jacobkeeler merged commit 3d2dc78 into develop Dec 9, 2020
@jacobkeeler jacobkeeler deleted the fix/on_way_point_change_from_mobile branch December 9, 2020 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants