Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxBitrate in VIDEO_STREAMING capability is read in wrong unit #882

Closed
shiniwat opened this issue Oct 2, 2018 · 0 comments
Closed

maxBitrate in VIDEO_STREAMING capability is read in wrong unit #882

shiniwat opened this issue Oct 2, 2018 · 0 comments

Comments

@shiniwat
Copy link
Contributor

shiniwat commented Oct 2, 2018

Bug Report

maxBitrate in VIDEO_STREAMING capability is read in wrong unit

Reproduction Steps
  1. Start video streaming SDL app and make sure RegisterAppInterface get succeeded with video capable HU.
  2. send GetSystemCapability {"systemCapabilityType":"VIDEO_STREAMING"}
  3. make sure getting GetSystemCapability response, something like:
    "systemCapability" : {
    "systemCapabilityType" : "VIDEO_STREAMING",
    "videoStreamingCapability" : {
    "hapticSpatialDataSupported" : false,
    "maxBitrate" : 10000,
    "preferredResolution" : {
    "resolutionHeight" : 416,
    "resolutionWidth" : 800
    },
    "supportedFormats" : [
    {
    "codec" : "H264",
    "protocol" : "RTP"
    },
    {
    "codec" : "H264",
    "protocol" : "RAW"
    }
    ]
    }
    }
  4. startVideoStreaming with given VideoStreamingParams.
Expected Behavior

Video streaming works in appropriate bitrate.

Observed Behavior

Video streaming on HU looks very poor quality.

OS & Version Information
  • Android Version: Android 7.0 (Samsung Galaxy S8)
  • SDL Android Version: commit daaac59 from develop branch
  • Testing Against: running on our video-capable dev-board
Test Case, Sample Code, and / or Example App

I will create PR later, but in short, it is a bug in VideoStreamingParameters class.
According to hmi_integration_guideline, maxBitrate is described as "The maximum bitrate of video stream that is supported, in kbps.", but the code treats it as bps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants