Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API discrepancies between sdl_core and rpc_spec #49

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Fix API discrepancies between sdl_core and rpc_spec #49

merged 1 commit into from
Sep 26, 2017

Conversation

jacobkeeler
Copy link
Contributor

@jacobkeeler jacobkeeler commented Sep 21, 2017 •
edited
Loading

Resolves differences between the SDL Core MOBILE_API and this repo.

  • Moved new enums to enum section
  • Corrected order of new RPCs to be sorted by Function ID
  • Added mandatory flag where necessary
  • Fixed formatting issues in xml
  • Added missing READ_ONLY result
  • Added info field to SendHapticData response
  • Removed nonexistent "CORRUPTED_DATA" result from PutFile (tied to CRC proposal that hasn't yet been implemented)

@jacobkeeler
Resolve API discrepancies
746b820 
Resolves differences between the SDL Core MOBILE_API and this repo
@jacobkeeler jacobkeeler mentioned this pull request Sep 22, 2017
Merged
@joeygrover joeygrover merged commit d0e728c into feature/4_5_0_Updated Sep 26, 2017
@joeygrover joeygrover deleted the fix/API_Discrepancies branch September 26, 2017 19:38
@theresalech theresalech mentioned this pull request Feb 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeygrover joeygrover joeygrover approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobkeeler @joeygrover