[SDL-0296] Possibility to update video streaming capabilities during ignition cycle #272
Conversation
Currently InterfaceParser is not able to generate recursive structures
i.e. one or several structure attributes have its own type e.g.:
struct VideoStreamingCapability {
...
VideoStreamingCapability additionalVideoStreamingCapabilities;
}
because structure type fully defined only when all of it attributes are
defined.
With this commit InterfaceParser is able to handle such problem.
…bility_to_update_video_streaming_capabilities
LitvinenkoIra
force-pushed
the
feature/0296_possibility_to_update_video_streaming_capabilities
branch
from
5f7c9ed to
7245fbd
Compare
|
@atiwari9 please review this PR |
There was a problem hiding this comment.
Approved the PR with below commits:
Test Results:
Logs:
2020-08-19_15-57-51.zip
TOTAL: 44
PASSED: 42
FAILED: 0
ABORTED: 0
SKIPPED: 2
SDL Core: 36f2f377929c52f84cb4b4216795fcc5c96f58b4
RPC Spec: 4d1312648b78b69f881d97b4b9fd0d8291736750
SDL HMI: 788499f2078e522d710dce3f413045277b278785
Test Scripts: e6d7f578d52c3b932bc2c5ed9465e9d0c8fd8979
Please resolve any merge conflicts.
…bility_to_update_video_streaming_capabilities
LitvinenkoIra
force-pushed
the
feature/0296_possibility_to_update_video_streaming_capabilities
branch
2 times, most recently
from
e87238a to
85e868f
Compare
|
@jordynmackool @JackLivio This PR is ready for Livio review. Thank you! |
kboskin
force-pushed
the
feature/0296_possibility_to_update_video_streaming_capabilities
branch
from
85e868f to
44042a7
Compare
|
@LitvinenkoIra There seem to be some changes from develop in the MOBILE_API.xml file which are being removed/overwritten in this PR (such as the Is it possible to revert that commit and try merging in the changes from develop again (or using the develop version and adding in the new video streaming capability parameters again)? |
…bility_to_update_video_streaming_capabilities
LitvinenkoIra
force-pushed
the
feature/0296_possibility_to_update_video_streaming_capabilities
branch
from
8a91261 to
166c5be
Compare
|
@ShobhitAd Oh I see, sorry for that. I've updated the merge, but I had to force push the branch. Now it should be ok |
|
@ShobhitAd I can see that this PR is still have conflicts, but I'm not sure that the latest commit from the develop branch is correct, could you please check it 0110478 |
@LitvinenkoIra Merged #313 to fix the issue. |
…bility_to_update_video_streaming_capabilities
Mobile API updates according to the #273
smartdevicelink/sdl_core#3465
This PR is ready for review.