Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/0266 new vehicle data gear status #252

Conversation

mkorniichuk
Copy link
Contributor

Implements #3216

Summary

Current PR contains an update for MOBILE_API.xml and README.md introducing new vehicle data type gearStatus

MOBILE_API.xml Outdated
<description>See PRNDL</description>
<history>
<param name="prndl" type="Boolean" mandatory="false" since="1.0" until="6.2"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IGapchuk change to since=2.0

MOBILE_API.xml Outdated
<description>See PRNDL</description>
<history>
<param name="prndl" type="Boolean" mandatory="false" since="1.0" until="6.2"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IGapchuk change to since 2.0

MOBILE_API.xml Outdated
<description>See PRNDL</description>
<history>
<param name="prndl" type="VehicleDataResult" mandatory="false" since="1.0" until="6.2"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IGapchuk change to since 2.0

MOBILE_API.xml Outdated
<description>See PRNDL</description>
<history>
<param name="prndl" type="Boolean" mandatory="false" since="1.0" until="6.2"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IGapchuk change to since 2.0 in all related places

@LitvinenkoIra
Copy link
Contributor

@atiwari9 please review this PR

@atiwari9
Copy link

PR Approved.

Validated with atf scripts commit: b4e023d

Logs:Test_Report_Gear_Status_b4e023d_2.zip

@LitvinenkoIra
Copy link
Contributor

@theresalech PR is ready for Livio review. Thank you!

@theresalech
Copy link
Contributor

@LitvinenkoIra, thanks! Moving forward, is it possible for Luxoft to reference the issues for the specific repos in the PR description? For example, this PR resolves issue #217.

@LitvinenkoIra
Copy link
Contributor

@theresalech Yes, I will check all of the PR's and will link them.

MOBILE_API.xml Outdated Show resolved Hide resolved
MOBILE_API.xml Outdated Show resolved Hide resolved
MOBILE_API.xml Outdated Show resolved Hide resolved
MOBILE_API.xml Outdated Show resolved Hide resolved
MOBILE_API.xml Outdated Show resolved Hide resolved
MOBILE_API.xml Outdated Show resolved Hide resolved
MOBILE_API.xml Outdated Show resolved Hide resolved
MOBILE_API.xml Outdated Show resolved Hide resolved
MOBILE_API.xml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@LitvinenkoIra
Copy link
Contributor

@ShobhitAd All comments are processed, please check the latest updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants