Pixel Density And Scale #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresalech
approved these changes
Aug 6, 2019
theresalech
requested changes
Aug 6, 2019
iCollin
reviewed
Aug 21, 2019
Co-Authored-By: Collin <[email protected]>
|
@theresalech @iCollin Updated |
theresalech
requested changes
Aug 21, 2019
MOBILE_API.xml
Outdated
| @@ -2872,6 +2872,15 @@ | |||
| <param name="hapticSpatialDataSupported" type="Boolean" mandatory="false"> | |||
| <description>True if the system can utilize the haptic spatial data from the source being streamed. If not included, it can be assumed the module doesn't support haptic spatial data'. </description> | |||
| </param> | |||
| <param name="diagonalScreenSize" type="Float" mandatory="false" since="6.0"> | |||
There was a problem hiding this comment.
Need minvalue of 1 per proposal revisions
MOBILE_API.xml
Outdated
| <param name="diagonalScreenSize" type="Float" mandatory="false" since="6.0"> | ||
| <description>The diagonal screen size in inches.</description> | ||
| </param> | ||
| <param name="pixelPerInch" type="Float" mandatory="false" since="6.0"> |
There was a problem hiding this comment.
Need minvalue of 1 per proposal revisions
There was a problem hiding this comment.
I believe the revisions had minvalue="0" for pixelPerInch and diagonalScreenSize
|
@theresalech Updated |
theresalech
approved these changes
Sep 24, 2019
joeygrover
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107