Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0317] SDL Protocol Security Specification #41

Conversation

AKalinich-Luxoft
Copy link
Contributor

Implements #40

@AKalinich-Luxoft AKalinich-Luxoft changed the title Added SDL protocol security specification [SDL 0317] SDL Protocol Security Specification Jun 17, 2021
@AKalinich-Luxoft
Copy link
Contributor Author

@theresalech this PR is ready for Livio review

@theresalech
Copy link

@AKalinich-Luxoft , can you please advise if this PR has already been reviewed and approved by a member of the Ford team? We will begin our review after a Ford team member has provided their approval on the PR. Thank you!

@mrapitis
Copy link

@theresalech Ford has reviewed and approved of this PR. Thanks!

@theresalech theresalech linked an issue Jun 17, 2021 that may be closed by this pull request
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Jacob Keeler <[email protected]>
@AKalinich-Luxoft
Copy link
Contributor Author

@jacobkeeler all comments have been processed. Would you have a chance to proceed with the review here?

@jacobkeeler
Copy link
Contributor

jacobkeeler commented Aug 5, 2021

@AKalinich-Luxoft Ah, so we've been holding off on officially approving this because there is some testing we need to do to verify there aren't any legacy issues with this specification. Currently this spec isn't properly implemented in either of the mobile libraries (see smartdevicelink/sdl_ios#2024 and smartdevicelink/sdl_java_suite#1720), and we're in the process of fixing this. As a result, we are currently planning to test these updates against a number of legacy systems to verify that everything still works properly (and if not, we would submit a revision to the proposal which accounts for this).

I can approve this PR for now if we need to, but we will need to hold off on merging until this testing is performed.

Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added suggestions for rewriting the Send Handshake Data description for clarity, in addition to a note describing incorrect behavior in older versions of Core.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed some small formatting issues

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@jacobkeeler jacobkeeler changed the base branch from master to release/5.4.1 September 22, 2021 15:59
@jacobkeeler jacobkeeler merged commit d65fb9e into smartdevicelink:release/5.4.1 Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDL 0317] SDL Protocol Security Specification
4 participants