Merge keyboard properties partially to allow for proper reset #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Byrne
reviewed
Feb 17, 2021
| } | ||
| if (!action.keyboardProperties.language) { | ||
| keyboardProperties.language = app.keyboardProperties.language; | ||
| } |
There was a problem hiding this comment.
Set KeyPressMode if omitted?
<param name="keypressMode" type="Common.KeypressMode" mandatory="false" >
<description>
Desired keypress mode.
If omitted, this value will be set to RESEND_CURRENT_ENTRY.
</description>
</param>
Jack-Byrne
approved these changes
Feb 17, 2021
Jack-Byrne
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with #348
Testing Plan
Core Tests
Set all keyboard properties via SetGlobalProperties to non-standard values, then send ResetGlobalProperties. Keyboard should be in its default state.
Core version / branch / commit hash / module tested against: develop
Proxy+Test App name / version / branch / commit hash / module tested against: RPC Builder JS, master
Summary
Partially merge keyboard properties so that ResetGlobalProperties works properly.
Changelog
Bug Fixes
CLA