Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard Fixes #353

Merged
merged 8 commits into from
Feb 12, 2021
Merged

Keyboard Fixes #353

merged 8 commits into from
Feb 12, 2021

Conversation

Jack-Byrne
Copy link
Collaborator

@Jack-Byrne Jack-Byrne commented Feb 12, 2021

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Core Tests

  1. Test initialText for keyboard
  2. Test keyboardEnter behavior
  3. Test user mask input callback
  4. Test custom keys dont overwrite layouts

Core version / branch / commit hash / module tested against: develop
Proxy+Test App name / version / branch / commit hash / module tested against: keyboard enhancements

Summary of changes:

Apparently React constructors are important and having static props do not update every time the component goes in and out of view.

CLA

@Jack-Byrne Jack-Byrne merged commit 3fec8d4 into develop Feb 12, 2021
@Jack-Byrne Jack-Byrne deleted the fix/keyboard_updates branch February 12, 2021 21:28
Copy link
Collaborator

@iCollin iCollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants