Feature/video streaming #345
Conversation
| @@ -174,12 +178,13 @@ def __init__(self, _websocket, _path): | |||
| "InstallApp": RPCService.webengine_manager.handle_install_app, | |||
| "GetInstalledApps": RPCService.webengine_manager.handle_get_installed_apps, | |||
| "UninstallApp": RPCService.webengine_manager.handle_uninstall_app, | |||
| "StartVideoStream": self.handle_start_video_stream, | |||
There was a problem hiding this comment.
I think there needs to be a message added for Stopping a video stream.
fix reference to other function
Co-authored-by: Collin <[email protected]>
…fmpeg unsupported
|
|
||
| if (this.webmSupport === undefined) { | ||
| var video = document.getElementById('navi_stream'); | ||
| this.webmSupport = 'probably' === video.canPlayType('video/webm; codecs="vp8"'); |
There was a problem hiding this comment.
This returns 'probably'?
There was a problem hiding this comment.
probably, maybe, or an empty string if it knows it does not support
it can never be sure cause there are still like bitrate limits etc
…ional array set to capabilities to empty array
tools/start_server.py
Outdated
|
|
||
| elif not _params['webm']: | ||
| print('\033[33mYour browser does not support WEBM video\033[0m') | ||
| if _params['config']['protocol'] == 'RAW' and _params['config']['protocol'] == 'H264': |
There was a problem hiding this comment.
| if _params['config']['protocol'] == 'RAW' and _params['config']['protocol'] == 'H264': | |
| if _params['config']['protocol'] == 'RAW' and _params['config']['codec'] == 'H264': |
There was a problem hiding this comment.
applied in ba8ca35
tools/start_server.py
Outdated
| if 'config' not in _params: | ||
| return self.gen_error_msg('Missing mandatory param \'config\'') | ||
|
|
||
| if _params['config']['protocol'] == 'RTP': |
There was a problem hiding this comment.
I would recommend to use get() instead of direct map access because all config parameters are not mandatory. Python will throw the exception if you try to access key which does not exist
There was a problem hiding this comment.
good idea, non mandatory access replaced with get in ba8ca35
Adds Video Streaming
Fixes #38
Fixes #290
Fixes #315