Fix issues with updating template images #338
Conversation
src/js/Templates/Shared/Image.js
Outdated
| @@ -7,13 +7,21 @@ class Image extends React.Component { | |||
| constructor(props) { | |||
| super(props); | |||
| this.state = {error: false, refreshed: false}; | |||
| this.canvasStyle = { | |||
| this.customCanvasStyle = { | |||
There was a problem hiding this comment.
@JackLivio can you clarify the purpose of this variable? Is the intention that someone who adopts the generic HMI will modify the customCanvasStyle value here in the constructor to hardcode canvas sizes for the whole HMI?
This variable currently has no effect on how an Image is rendered.
There was a problem hiding this comment.
@iCollin Referring to canvasStyle before the changes in the pr, that object was created to store the canvasContainer height and width. There was a strange issue in safari where the canvasContainer height would increase when the image in a button that was clicked on, and it would drive the image down the page.
jacobkeeler
force-pushed
the
fix/template_image_updating
branch
from
45dd957 to
6f5438e
Compare
|
@iCollin Rebased commits, unfortunately it did require a force-push, but the changes were directly cherry-picked from the 3 original commits |
There was a problem hiding this comment.
Testing went well, approved.
One question I have though, do you think we should leave the default canvas size as 300? I mistyped my image name at first, and the text was forced outside of an alert softbutton because by default the canvas was 300x75. This would also apply in the case an image upload failed. Would it make sense to use a smaller default canvas size?
Fixes #323
Summary of Changes:
Image.js