-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic Menu and Image Capabilities #285
Conversation
…_sub_menus # Conflicts: # build/bundle.js # src/css/base/_base.scss # src/js/AppHeader.js # src/js/HScrollMenu.js # src/js/InAppList.js # src/js/InAppMenu.js # src/js/VScrollMenu.js # src/js/VScrollMenuItem.js # src/js/actions.js # src/js/containers/AppsButton.js # src/js/containers/Menu.js # src/js/containers/MenuIcon.js # src/js/containers/SubMenu.js # src/js/entry.js # src/js/reducers.js
…nu_and_image_updates # Conflicts: # src/css/base/_base.scss # src/js/Controllers/DisplayCapabilities.js # src/js/HScrollMenu.js # src/js/MenuFooter.js # src/js/VScrollMenuItem.js # src/js/containers/Menu.js # src/js/containers/SubMenu.js
An additional issue I ran into, it looks like the HMI will crash if an app is disconnected while on the menu screen. This is the error I get in such a case:
|
Some smaller comments still need to be addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seeing this issue for nested submenus: #285 (comment)
I noticed when testing that images that are not templated do not show up in the menu even though they have been uploaded to core and I can see them in the storage folder. Scrolling does not make the non-templated images show up. The only way I can get the images to show up is to close the menu and re-open it. If I use templated images, everything seems to work as expected. |
…nu_and_image_updates # Conflicts: # src/js/Controllers/RpcFactory.js
Fixes #234
Based off of the additional sub menus pr.