Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Menu and Image Capabilities #285

Merged
merged 17 commits into from
Aug 20, 2020

Conversation

Jack-Byrne
Copy link
Collaborator

@Jack-Byrne Jack-Byrne commented Jun 30, 2020

Fixes #234

Based off of the additional sub menus pr.

…_sub_menus

# Conflicts:
#	build/bundle.js
#	src/css/base/_base.scss
#	src/js/AppHeader.js
#	src/js/HScrollMenu.js
#	src/js/InAppList.js
#	src/js/InAppMenu.js
#	src/js/VScrollMenu.js
#	src/js/VScrollMenuItem.js
#	src/js/actions.js
#	src/js/containers/AppsButton.js
#	src/js/containers/Menu.js
#	src/js/containers/MenuIcon.js
#	src/js/containers/SubMenu.js
#	src/js/entry.js
#	src/js/reducers.js
@jacobkeeler jacobkeeler changed the base branch from develop to feature/additional_sub_menus July 22, 2020 18:18
@jacobkeeler jacobkeeler changed the base branch from feature/additional_sub_menus to develop July 22, 2020 18:18
…nu_and_image_updates

# Conflicts:
#	src/css/base/_base.scss
#	src/js/Controllers/DisplayCapabilities.js
#	src/js/HScrollMenu.js
#	src/js/MenuFooter.js
#	src/js/VScrollMenuItem.js
#	src/js/containers/Menu.js
#	src/js/containers/SubMenu.js
@jacobkeeler
Copy link
Contributor

An additional issue I ran into, it looks like the HMI will crash if an app is disconnected while on the menu screen. This is the error I get in such a case:

scheduler.production.min.js:96 Uncaught TypeError: Cannot read property 'menu' of undefined
    at Function.Pn [as mapToProps] (Menu.js:13)
    at r (wrapMapToProps.js:41)
    at selectorFactory.js:44
    at m (selectorFactory.js:58)
    at selectorFactory.js:63
    at e.d (connectAdvanced.js:64)
    at e.t.handleChangeWrapper (Subscription.js:95)
    at Subscription.js:23
    at el (react-dom.production.min.js:5919)
    at Object.notify (Subscription.js:19)

jacobkeeler
jacobkeeler previously approved these changes Aug 13, 2020
@jacobkeeler jacobkeeler dismissed their stale review August 13, 2020 20:40

Some smaller comments still need to be addressed

Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing this issue for nested submenus: #285 (comment)

@NicoleYarroch
Copy link
Contributor

I noticed when testing that images that are not templated do not show up in the menu even though they have been uploaded to core and I can see them in the storage folder. Scrolling does not make the non-templated images show up. The only way I can get the images to show up is to close the menu and re-open it. If I use templated images, everything seems to work as expected.

…nu_and_image_updates

# Conflicts:
#	src/js/Controllers/RpcFactory.js
@Jack-Byrne Jack-Byrne merged commit 3585259 into develop Aug 20, 2020
@Jack-Byrne Jack-Byrne deleted the feature/dynamic_menu_and_image_updates branch August 20, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants