Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/DF-20625 apex #3672

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Feat/DF-20625 apex #3672

merged 3 commits into from
Feb 5, 2025

Conversation

mmcallister-cll
Copy link
Contributor

@mmcallister-cll mmcallister-cll commented Feb 4, 2025

Closes #DF-20625

Description

Apex EA initial commit, tested against UAT endpoints

Steps to Test

  1. yarn test apex
  2. test with payload
{
    "data": {
        "endpoint": "nav",
        "accountName": "<accountName>"
    }
}

Quality Assurance

  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant infra-k8s configuration file.
  • If a new adapter was made, or an existing one was modified so that its environment variables have changed, update the relevant adapter-secrets configuration file or update the soak testing blacklist.
  • If a new adapter was made, or a new endpoint was added, update the test-payload.json file with relevant requests.
  • The branch naming follows git flow (feature/x, chore/x, release/x, hotfix/x, fix/x) or is created from Jira.
  • This is related to a maximum of one Jira story or GitHub issue.
  • Types are safe (avoid TypeScript/TSLint features like any and disable, instead use more specific types).
  • All code changes have 100% unit and integration test coverage. If testing is not applicable or too difficult to justify doing, the reasoning should be documented explicitly in the PR.

@mmcallister-cll mmcallister-cll requested a review from a team February 4, 2025 23:08
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: 5c84060

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@chainlink/apex-adapter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mxiao-cll
mxiao-cll previously approved these changes Feb 4, 2025
packages/sources/apex/src/transport/nav.ts Outdated Show resolved Hide resolved
packages/sources/apex/src/transport/nav.ts Outdated Show resolved Hide resolved
packages/sources/apex/test-payload.json Show resolved Hide resolved
@mmcallister-cll mmcallister-cll merged commit 805468b into main Feb 5, 2025
6 of 8 checks passed
@mmcallister-cll mmcallister-cll deleted the feat/DF-20625-apex branch February 5, 2025 16:22
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants