TOML config: implement remaining interfaces

[jmank88]

https://app.shortcut.com/chainlinklabs/story/33615/create-new-implementation-of-chainscopedconfig-generalconfig-interfaces-that-sources-config-from-a-config-toml-file
https://app.shortcut.com/chainlinklabs/story/37975/chains-nodes-should-be-read-from-the-config-interface

• added BlockBackfillDepth & BlockBackfillSkip fallback values
• added v2.ChainScoped to implement config.ChainScopedConfig with a gencfg.BasicConfig and v2.EVMConfig
• refactored monolithic setFrom() methods to be per-struct
• expanded unique name & URL validation cross chains of the same type
• updated graphql & node controllers to use Name instead of ID from database (still unqiue)
• added TOML Chain and ChainSet variants
• added immutable TOML ORM variants
• pull core defaults from docs
• test EVM fallback defaults against docs
• rename GeneralOnlyConfig to BasicConfig and move some GlobalConfig methods
• added standard ErrUnsupported error ("unsupported with config v2")
• cleaner validation error format

Configuration Transition

- subgraph names are packages
- thick lines indicate control flow
- dotted lines indicate implicit interface implementation
- regular w/ dot indicate implementation types

flowchart LR

    subgraph cmd
    
        subgraph cmd/app
            NewApp([func NewApp])     
        end
    
        cli>$ chainlink node start]
        
        RunNode([func Client.RunNode])
        
        NewApplication([func NewApplication])
            
        cli == 1. Before ==> NewApp
        cli == 2. Action ==> RunNode
        RunNode ==> NewApplication
    
    end
    
    toml{{TOML?}}    
    
    subgraph services/chainlink
        
        Config[[Config]]
        
        NewTOMLGeneralConfig([func NewTOMLGeneralConfig])
        
        generalConfig --o Config
        
        NewTOMLGeneralConfig --> generalConfig
       
    end
    
    subgraph config
    
        BasicConfig(BasicConfig)
        
        NewGeneralConfig([func NewGeneralConfig])
        
        generalConfig2[generalConfig]
        
        NewGeneralConfig --> generalConfig2
    
        subgraph config/v2
        
            Core[[Core]]
        
        end
    
    end
    
    Config --o Core
    
    NewApp ==> toml
    toml == yes ==> NewTOMLGeneralConfig
    toml == no ==> NewGeneralConfig
    generalConfig -.-> BasicConfig
    generalConfig2 -.-> BasicConfig
    
    
    subgraph chains/evm
    
        LoadChainSet([func LoadChainSet])
        tomlChain{{TOML?}}
        LoadChainSet ==> tomlChain
    
        subgraph chains/evm/config  
        
            NewChainScopedConfig([func NewChainScopedConfig])
        
            ChainScopedOnlyConfig(ChainScopedOnlyConfig)
            
            chainScopedConfig
            
            NewChainScopedConfig --> chainScopedConfig
            
            chainScopedConfig -.-> ChainScopedOnlyConfig
            
            subgraph chains/evm/config/v2 
            
                NewTOMLChainScopedConfig([func NewTOMLChainScopedConfig])
            
                ChainScoped
                
                NewTOMLChainScopedConfig --> ChainScoped
                
                ChainScoped -.-> ChainScopedOnlyConfig
                
                EVMConfig[[EVMConfig]]
                
            end
        
        end
        
        tomlChain == no ==>NewChainScopedConfig
        tomlChain == yes ==>NewTOMLChainScopedConfig
        Config --o EVMConfig
    end
    
    chainScopedConfig --o generalConfig
    ChainScoped --o generalConfig2 
    
    NewApplication ==> LoadChainSet
    

Loading

https://github.com/smartcontractkit/chainlink/blob/sc-33615-chain-scoped-config/core/services/chainlink/CONFIG.md

TODO

• Non-EVM chain defaults
• match legacy validation
• Expose configv2 endpoint in graphql #7490
• Audit Logs Rebase #7443
• add standard deprecation comments, e.g. // https://app.shortcut.com/chainlinklabs/story/33622/remove-legacy-config (cannot use proper // Deprecation yet tag since staticcheck blocks usages)
• "EvmGasBumpTxDepth should default to EvmMaxInFlightTransactions and may not be set larger than this" to follow-up
• graphql: did I break the UI? yes, but then I fixed it

operator-ui screenshots

Requires:

• pkg/terra/config: toml config defaults chainlink-cosmos#308
• relayer/pkg/chainlink/config: toml config defaults chainlink-starknet#138
• pkg/solana/config: toml config defaults chainlink-solana#403

[github-actions]

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

[github-actions]

Solana Smoke Test Results

1 tests   1 ✔️  4m 39s ⏱️
1 suites  0 💤
1 files    0 ❌

Results for commit d241683.

♻️ This comment has been updated with latest results.

[github-actions]

EVM Smoke Test Results

75 tests   33 ✔️  6m 22s ⏱️
  1 suites  42 💤
  1 files      0 ❌

Results for commit d241683.

♻️ This comment has been updated with latest results.

[samsondav]

Nice! Was this generated or did you write it?

[jmank88]

✋ 🖌️

[jmank88]

@vyzaldysanchez @samsondav This should probably be moved to secrets.toml, no?

[vyzaldysanchez]

This may require changes in the UI, depending on what's being done there with this value.

[jmank88]

We can optionally drop the display column since it is redundant now, but the rest I think I will be able to patch up.

[samsondav]

A better name 👍

[jmank88]

I don't recall if I explained the nuance of this change anywhere, but for posterity: I moved some methods between the two interfaces to align the abstractions with how we were using them. The old sets were intuitive for humans, but this way some uses could be reduced to just one interface or the other. (and we avoid another set of unimplemented/panicing v2 methods)