rename tx models and refactor to use Ethereum specific types #7
+233
−171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- models.EthTx => models.Tx - models.EthTxAttempts => models.TxAttempt - models.Tx#Signable => models.Tx#EthTx
dimroc
approved these changes
Jan 8, 2018
store/models/eth.go
Outdated
| @@ -29,9 +29,9 @@ func (self *EthTx) Signable(gasPrice *big.Int) *types.Transaction { | |||
| ) | |||
| } | |||
|
|
|||
| type EthTxAttempt struct { | |||
| type TxAttempt struct { | |||
There was a problem hiding this comment.
I hope xargs sed came in handy
| input models.RunResult, | ||
| store *store.Store, | ||
| ) models.RunResult { | ||
| recipient, err := utils.StringToAddress(e.Address) |
internal/cltest/fixtures.go
Outdated
| Value: big.NewInt(0), | ||
| GasLimit: big.NewInt(250000), | ||
| } | ||
| } | ||
|
|
||
| func CreateTxAndAttempt( | ||
| store *store.Store, | ||
| from string, | ||
| from common.Address, |
There was a problem hiding this comment.
Love the switch to stronger types.
jordanbonilla
pushed a commit
that referenced
this pull request
Feb 15, 2018
rename tx models and refactor to use Ethereum specific types
rupurt
added a commit
that referenced
this pull request
Apr 8, 2019
remove unused symbolic link public
rupurt
pushed a commit
that referenced
this pull request
Jan 22, 2020
…-ropsten-pairs-on-aggregator-app Add several new ropsten pairs on aggregator app
rupurt
pushed a commit
that referenced
this pull request
Jan 23, 2020
…-ropsten-pairs-on-aggregator-app Add several new ropsten pairs on aggregator app
rupurt
pushed a commit
that referenced
this pull request
Jan 23, 2020
…-ropsten-pairs-on-aggregator-app Add several new ropsten pairs on aggregator app
rupurt
pushed a commit
that referenced
this pull request
Jan 29, 2020
…-ropsten-pairs-on-aggregator-app Add several new ropsten pairs on aggregator app
rupurt
pushed a commit
that referenced
this pull request
Jan 31, 2020
…-ropsten-pairs-on-aggregator-app Add several new ropsten pairs on aggregator app
rupurt
pushed a commit
that referenced
this pull request
Jan 31, 2020
…-ropsten-pairs-on-aggregator-app Add several new ropsten pairs on aggregator app
asoliman92
pushed a commit
that referenced
this pull request
Jul 31, 2024
Co-authored-by: Mateusz Sekara <[email protected]>
Tofel
added a commit
that referenced
this pull request
Aug 2, 2024
# This is the 1st commit message: update contract # This is the commit message #2: make scripts executable # This is the commit message #3: upload base too # This is the commit message #4: try again # This is the commit message #5: gather changesets, print products out of scope # This is the commit message #6: fix product finding # This is the commit message #7: try again # This is the commit message #8: debug # This is the commit message #9: debug 2 # This is the commit message #10: grab only modified or added changesets # This is the commit message #11: try again 1 # This is the commit message #12: remove early exit # This is the commit message #13: place changesets in a subfolder in final artifact # This is the commit message #14: validate whether everything was generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses Ethereum's Address and Hash types instead of just strings.