CCIP-5139 Add Support for SVM ATA to USDCTokenPool and send correct tokenReceiver to token pools #16226
Conversation
Static analysis results are availableHey @0xsuryansh, you can view Slither reports in the job summary here or download them as artifact here. |
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
app-token-issuer-infra-releng
bot
requested review from
a team,
AnieeG,
kylesmartin,
jmank88,
pavel-raykov and
DylanTinianov
as code owners
app-token-issuer-infra-releng
bot
requested review from
winder,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara,
0xAustinWang and
0xnogo
0xsuryansh
changed the title
Solidity Review Jira issueHey! We have taken the liberty to link this PR to a Jira issue for Solidity Review. This is a new feature, that's currently in the pilot phase, so please make sure that the linkage is correct. In a contrary case, please update it manually in JIRA and replace Solidity Review issue key in the changeset file with the correct one. Any changes to the Solidity Review Jira issue should be reflected in the changeset file. If you need to update the issue key, please do so manually in the following changeset file: This PR has been linked to Solidity Review Jira issue: CCIP-3966 |
…okenReceiver to token pools
0xsuryansh
force-pushed
the
CCIP-5139_fix_onramp-usdcpool-tokenreceiver-chainfamily
branch
from
65fbc91 to
e60ac44
Compare
0xsuryansh
force-pushed
the
CCIP-5139_fix_onramp-usdcpool-tokenreceiver-chainfamily
branch
from
b5bf4f5 to
5cd6dc9
Compare
…kenreceiver-chainfamily' into CCIP-5139_fix_onramp-usdcpool-tokenreceiver-chainfamily # Conflicts: # core/gethwrappers/ccip/generated/fee_quoter/fee_quoter.go # core/gethwrappers/ccip/generated/onramp/onramp.go # core/gethwrappers/ccip/generated/onramp_with_message_transformer/onramp_with_message_transformer.go # core/gethwrappers/ccip/generation/generated-wrapper-dependency-versions-do-not-edit.txt
| @@ -72,6 +72,10 @@ contract USDCTokenPool is TokenPool, ITypeAndVersion { | |||
| // A mapping of CCIP chain identifiers to destination domains | |||
| mapping(uint64 chainSelector => Domain CCTPDomain) private s_chainToDomain; | |||
|
|
|||
| // Mapping specifically for SVM chains, stores a fixed ATA for each chain | |||
There was a problem hiding this comment.
Needs more information why this is done. Anyone should be able to understand without additional context.
There was a problem hiding this comment.
Moving USDC changes to new PR
| @@ -72,6 +72,10 @@ contract USDCTokenPool is TokenPool, ITypeAndVersion { | |||
| // A mapping of CCIP chain identifiers to destination domains | |||
| mapping(uint64 chainSelector => Domain CCTPDomain) private s_chainToDomain; | |||
|
|
|||
| // Mapping specifically for SVM chains, stores a fixed ATA for each chain | |||
| // The corresponding ATA is passed as mintRecipient when calling depositForBurnWithCaller | |||
| mapping(uint64 chainSelector => bytes32 associatedTokenAccount) private s_chainToAssociatedTokenAccount; | |||
There was a problem hiding this comment.
All of this needs to be applied to the hybrid pool as well
There was a problem hiding this comment.
Ack, will address in new PR
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
RensR
deleted the
CCIP-5139_fix_onramp-usdcpool-tokenreceiver-chainfamily
branch
…tokenReceiver to token pools (#16226) * CCIP-5139 Add Support for SVM ATA to USDCTokenPool and send correct tokenReceiver to token pools * fix tests * [Bot] Update changeset file with jira issues * Update gethwrappers * separate test for processPoolReturnData * fmt * lint fix * comment fix * fix * mockery run * golf * update comment for processMessageArgs * wrapper update * Revert USDC ATA support * UPDC wrapper reset --------- Co-authored-by: app-token-issuer-infra-releng[bot] <120227048+app-token-issuer-infra-releng[bot]@users.noreply.github.com>
mintRecipientshould be a fixed ATA account, so we maintain a mapping of ATA per SVM chain