Add telemetry for flexible schemas #16079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsondav
force-pushed
the
MERC-6789
branch
3 times, most recently
from
0349e11 to
80b2d96
Compare
samsondav
force-pushed
the
MERC-6789
branch
2 times, most recently
from
6240547 to
e0614c2
Compare
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
samsondav
force-pushed
the
MERC-6789
branch
4 times, most recently
from
f2e881a to
2ec827c
Compare
jmank88
reviewed
Jan 28, 2025
jmank88
reviewed
Jan 29, 2025
|
jmank88
reviewed
Jan 29, 2025
|
|
||
| const ctxTelemetryKey contextKey = "telemetry" | ||
|
|
||
| func WithTelemetryCh(ctx context.Context, ch chan<- interface{}) context.Context { |
There was a problem hiding this comment.
This is very unusual and unidiomatic. Why do we need to use context to move this around?
vyzaldysanchez
approved these changes
Jan 29, 2025
kalverra
approved these changes
Jan 29, 2025
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement telemetry for LLO plugin (and flexible schemas specifically)