Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: cosmos & starknet LOOPP mode only #16039

Merged
merged 4 commits into from
Feb 7, 2025
Merged

core: cosmos & starknet LOOPP mode only #16039

merged 4 commits into from
Feb 7, 2025

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Jan 22, 2025 •
edited
Loading

@jmank88 jmank88 added the wip label Jan 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

archseer
archseer reviewed Jan 23, 2025
View reviewed changes
core/services/chainlink/relayer_factory.go Outdated
TOMLConfigs RawConfigs
func (r *RelayerFactory) NewCosmos(ks keystore.Cosmos, chainCfgs RawConfigs) (map[types.RelayID]loop.Relayer, error) {
loopKs := &keystore.CosmosLoopKeystore{Cosmos: ks}
return r.NewLOOPRelayer("Aptos", relay.NetworkCosmos, env.CosmosPlugin, loopKs, chainCfgs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return r.NewLOOPRelayer("Aptos", relay.NetworkCosmos, env.CosmosPlugin, loopKs, chainCfgs)
return r.NewLOOPRelayer("Cosmos", relay.NetworkCosmos, env.CosmosPlugin, loopKs, chainCfgs)

@jmank88 jmank88 force-pushed the loopp-only-cosmos-starknet branch 3 times, most recently from 5717ebc to 2637ef0 Compare February 3, 2025 13:40
This was referenced Feb 3, 2025
Merged
Merged
@jmank88 jmank88 force-pushed the loopp-only-cosmos-starknet branch 2 times, most recently from 63472c0 to 763c44a Compare February 3, 2025 16:43
jmank88
jmank88 commented Feb 3, 2025
View reviewed changes
tools/bin/goreleaser_utils
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually work since they aren't imported anymore.

jmank88
jmank88 commented Feb 3, 2025
View reviewed changes
plugins/chainlink.Dockerfile Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work anymore since they aren't imported (and we can't just go install since there are replaces)

This was referenced Feb 3, 2025
Merged
Merged
@jmank88 jmank88 force-pushed the loopp-only-cosmos-starknet branch from 763c44a to 18894f3 Compare February 3, 2025 18:50
jmank88
jmank88 commented Feb 3, 2025
View reviewed changes
tools/bin/goreleaser_utils
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will have to be expanded to support the go mod download approach

@jmank88 jmank88 force-pushed the loopp-only-cosmos-starknet branch from 18894f3 to 7f68121 Compare February 4, 2025 12:44
jmank88
jmank88 commented Feb 4, 2025
View reviewed changes
GNUmakefile Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go mod download works well in cases where pure go install does not.

jmank88
jmank88 commented Feb 4, 2025
View reviewed changes
tools/bin/goreleaser_utils Outdated Show resolved Hide resolved
jmank88
jmank88 commented Feb 4, 2025
View reviewed changes
plugins/chainlink.Dockerfile Outdated Show resolved Hide resolved
@jmank88 jmank88 force-pushed the loopp-only-cosmos-starknet branch from 7f68121 to c395840 Compare February 4, 2025 14:32
@jmank88 jmank88 requested a review from chainchad February 4, 2025 14:36
jmank88
jmank88 commented Feb 4, 2025
View reviewed changes
core/cmd/chains_commands_integration_test.go
@@ -0,0 +1,34 @@
//go:build integration
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moving these to separate files in order to gate with build tags

@smartcontractkit smartcontractkit deleted a comment from github-actions bot Feb 4, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Feb 4, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Feb 4, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Feb 4, 2025
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Feb 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 7, 2025

Flakeguard Summary

Ran new or updated tests between develop and 2e24716 (loopp-only-cosmos-starknet).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

2 Results
Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestTransfersController_CreateSuccess_From_BalanceMonitorDisabled 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.32s Unknown
TestTransfersController_TransferBalanceToLowError 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.44s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

pavel-raykov
pavel-raykov previously approved these changes Feb 7, 2025
View reviewed changes
@jmank88 jmank88 force-pushed the loopp-only-cosmos-starknet branch from 2e24716 to 5de3ed4 Compare February 7, 2025 13:51
@jmank88
Copy link
Contributor Author

jmank88 commented Feb 7, 2025

OK now the tests should pass. There were two subtle nil bugs, one in the test boilerplate and one in cosmos: smartcontractkit/chainlink-cosmos#430

@jmank88 jmank88 requested a review from pavel-raykov February 7, 2025 13:55
pavel-raykov
pavel-raykov previously approved these changes Feb 7, 2025
View reviewed changes
@jmank88 jmank88 force-pushed the loopp-only-cosmos-starknet branch from 5de3ed4 to 5c23664 Compare February 7, 2025 14:08
krehermann
krehermann previously approved these changes Feb 7, 2025
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
7 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarQube

@jmank88 jmank88 requested a review from pavel-raykov February 7, 2025 15:52
@jmank88 jmank88 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into develop with commit 4fc61bb Feb 7, 2025
123 of 129 checks passed
@jmank88 jmank88 deleted the loopp-only-cosmos-starknet branch February 7, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyzaldysanchez vyzaldysanchez vyzaldysanchez approved these changes

@pavel-raykov pavel-raykov pavel-raykov approved these changes

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19

@ilija42 ilija42 Awaiting requested review from ilija42

@chainchad chainchad Awaiting requested review from chainchad

@archseer archseer Awaiting requested review from archseer

@kalverra kalverra Awaiting requested review from kalverra

@krehermann krehermann Awaiting requested review from krehermann

@cedric-cordenier cedric-cordenier Awaiting requested review from cedric-cordenier

@chudilka1 chudilka1 Awaiting requested review from chudilka1

@aalu1418 aalu1418 Awaiting requested review from aalu1418

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jmank88 @archseer @vyzaldysanchez @krehermann @chainchad @pavel-raykov