Explicitly use protoc installed in the makefile. #16005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-raykov
requested review from
krehermann,
samsondav and
jmank88
and removed request for
krehermann
|
jmank88
approved these changes
Jan 21, 2025
krehermann
approved these changes
Jan 21, 2025
samsondav
approved these changes
Jan 21, 2025
This was referenced Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we interact with protoc as follows:
core/scripts/install-protoc.sh.core/scripts/install-protoc.shgomods -w go generate -x ./...and rely on//go:generate protoc ...directives to generate pb definitions.The 2. Step above actually only works !inside! the script, hence not updating the $PATH for the later
//go:generate protoc...invocation. This works on linux because protoc is installed in .local folder which is included in $PATH by default (https://unix.stackexchange.com/questions/316765/which-distributions-have-home-local-bin-in-path). But this does not work on MAC. This PR explicitly adds installed protoc folder to $PATH so that it is used in//go:generate protoc...calls. (On MAC themake generatecommand will use anyprotocinstalled, e.g.,/opt/homebrew/bin/protoc.)