Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using chainlink-framework/chains instead of chainlink/common. #15972

Merged
merged 17 commits into from
Jan 21, 2025

Conversation

pavel-raykov
Copy link
Collaborator

@pavel-raykov pavel-raykov commented Jan 17, 2025

This PR starts using newly created module chainlink-framework/chains instead of chainlink/common. It essentially does the following steps:

  • removes non-mock .go files from chainlink/common.
  • points the rest of the code to import chainlink-framework/chains by running the following substitutions in the relevant files
cat /tmp/grep_files.txt | while read line 
do
   sed -i '' -e 's="github.com/smartcontractkit/chainlink/v2/common/fees"="github.com/smartcontractkit/chainlink-framework/chains/fees"=' $line
   sed -i '' -e 's="github.com/smartcontractkit/chainlink/v2/common/txmgr"="github.com/smartcontractkit/chainlink-framework/chains/txmgr"=' $line
   sed -i '' -e 's="github.com/smartcontractkit/chainlink/v2/common/txmgr/types"="github.com/smartcontractkit/chainlink-framework/chains/txmgr/types"=' $line
   sed -i '' -e 's="github.com/smartcontractkit/chainlink/v2/common/types"="github.com/smartcontractkit/chainlink-framework/chains"=' $line
   sed -i '' -e 's="github.com/smartcontractkit/chainlink/v2/common/headtracker"="github.com/smartcontractkit/chainlink-framework/chains/headtracker"=' $line
   sed -i '' -e 's="github.com/smartcontractkit/chainlink/v2/common/headtracker/types"="github.com/smartcontractkit/chainlink-framework/chains/headtracker/types"=' $line
done
  • updates .mockery.yaml file to generate mocks based on the chainlink-framework/chains.

Requires

@pavel-raykov pavel-raykov requested a review from jmank88 January 17, 2025 17:25
@pavel-raykov pavel-raykov changed the title Move chainlink/common to chainlink-framework/chains. Start using chainlink-framework/chains instead of chainlink/common. Jan 17, 2025
Copy link
Contributor

github-actions bot commented Jan 17, 2025

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 3c2bacb (test-common-removed).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestETHKeysController_ChainSuccess_UpdateNonce 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.373333333s Unknown
TestTransfersController_CreateSuccess_From 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.366666666s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and 85c0921 (test-common-removed).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestETHKeysController_ChainSuccess_UpdateNonce 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.273333333s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@pavel-raykov pavel-raykov marked this pull request as ready for review January 21, 2025 20:23
@pavel-raykov pavel-raykov requested a review from a team as a code owner January 21, 2025 20:23
@pavel-raykov pavel-raykov requested review from a team as code owners January 21, 2025 20:23
Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and e6c1999 (test-common-removed).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestTransfersController_CreateSuccess_From_WEI 66.67% false false false 3 2 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.313333333s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

@cl-sonarqube-production
Copy link

Copy link
Contributor

Flakeguard Summary

Ran new or updated tests between develop and e6c1999 (test-common-removed).

View Flaky Detector Details | Compare Changes

Found Flaky Tests ❌

Name Pass Ratio Panicked? Timed Out? Race? Runs Successes Failures Skips Package Package Panicked? Avg Duration Code Owners
TestTransfersController_CreateSuccess_From_WEI 83.33% false false false 6 5 1 0 github.com/smartcontractkit/chainlink/v2/core/web false 1.333333333s Unknown

Artifacts

For detailed logs of the failed tests, please refer to the artifact failed-test-results-with-logs.json.

Copy link
Contributor

@DylanTinianov DylanTinianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@pavel-raykov pavel-raykov added this pull request to the merge queue Jan 21, 2025
Merged via the queue into develop with commit 7ba8f9a Jan 21, 2025
205 checks passed
@pavel-raykov pavel-raykov deleted the test-common-removed branch January 21, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants