Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chaintype.ChainZircuit to chaintypes with rollup support in L1 oracle #15913

Merged
merged 3 commits into from
Jan 15, 2025
Merged

Add chaintype.ChainZircuit to chaintypes with rollup support in L1 oracle #15913

merged 3 commits into from
Jan 15, 2025

Conversation

ogtownsend
Copy link
Collaborator

Motivation

  • Zircuit's chaintype was recently changed from optimismBedrock to zircuit
  • This means IsRollupWithL1Support() started returning false for zircuit
  • Which in turn meant no L1 oracle was created for Zircuit

Solution

  • Add zircuit to supportedChainTypes

@ogtownsend ogtownsend requested review from a team as code owners January 14, 2025 06:40
@ogtownsend ogtownsend mentioned this pull request Jan 14, 2025
Closed
@ogtownsend ogtownsend requested a review from a team as a code owner January 14, 2025 06:47
amit-momin
amit-momin previously approved these changes Jan 14, 2025
View reviewed changes
matYang
matYang previously approved these changes Jan 14, 2025
View reviewed changes
@ogtownsend ogtownsend dismissed stale reviews from matYang and amit-momin via c03beda January 14, 2025 17:08
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@ogtownsend ogtownsend added this pull request to the merge queue Jan 15, 2025
Merged via the queue into develop with commit d0a7df3 Jan 15, 2025
170 checks passed
@ogtownsend ogtownsend deleted the add-zircuit-to-rollup-supported-chaintypes branch January 15, 2025 18:32
This was referenced Jan 15, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amit-momin amit-momin amit-momin approved these changes

@jmank88 jmank88 jmank88 approved these changes

@matYang matYang matYang left review comments

@stackman27 stackman27 Awaiting requested review from stackman27

@vyzaldysanchez vyzaldysanchez Awaiting requested review from vyzaldysanchez vyzaldysanchez is a code owner automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ogtownsend @jmank88 @matYang @amit-momin