-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solana estimate providers no-op #15909
Solana estimate providers no-op #15909
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
|
||
// CalculateMerkleTreeGas is not implemented | ||
func (gp EstimateProvider) CalculateMerkleTreeGas(numRequests int) uint64 { | ||
return 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to check with @winder or others in CCIP team, if 0 is acceptable for the no-op here, or do we need a very large value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with @winder , "The estimate provider is used to determine if there is a gas spike. Returning 0 will ensure we don't reject a message due to a bad estimate."
|
* cleanup * update * fix mod * update * revert mod change * add changeset * fix smoke test * fix lint * revert go mod * fix * revert * revert * again * update * remove file * revert * update * update * update version * revert * downgrade version * go mod tidy * tidy * add token indexes * update comment * add solana and remove evm specific * add solana config * grammar * update go mod * go mod * update * update * changeset * update * refactor * update * refactor * update lint * fix lint * add chain reader config to plugin creator * update changeset * Part 1 for Prashant comments * refactor getTransmitterKeys * go mod tidy * minor * fix lint * go import * gomod * Blaž comments * part 1 * fix lint * data type * add solana home chain merge func * rephrase * add entire config from example * rm comments * lint * lint * refactor * update comments * fix lint * make generate * Add solana support to contract transmitter (#15869) * add solana support to contract transmitter * add changeset * one more place * address unsupported chain family * encode offramp addr * fix breaking change * rename * test * revert * update version * go mod * go mod tidy * go mod * go.md * go md * remove hard coded * go.md * go import * remove unused * update mod * update with new generated go binding * Amit comments * Solana estimate providers no-op (#15909) * no-op for solana estimate providers * add changeset * token data noop * noop for solana rmn * fix lint * mod tidy * Use SVM ABI, needs to check test * add comment * goimport * update * rename * go mod tidy * goimport * tidy * refactor * fix lint * step 1 for parse extra args map * add comment * fix test * fix * update * improvement * update * update * tidy * update * fix test * Matt comments * address Makram comments * Makram comments part1 * refactor * lint * go mod * update * fix * mod tidy * go md * gomd * fix import * fix broken integration test * change commit to little endian, to do for execute * update * use LE * update * update * update padding * fix make * fix test * rename * fix test * update source chain * update * lower case * update test * goimport * minor * tidy * implement and add test * update comments * goimport * implement dest exec data handling * fix conflicts * fix * fix * fix test * update * fix test * update * add comment * fix mod * fix * refactor * refactor * update * update comment * add unit test * update * lint * mod * mod tidy * fix * lint * update * update * goimport * update * Solana MessageHasher (#15911) * initial code * update * minor * update test * update * lint * change set * update * update * update token data and test * update * fix test --------- Co-authored-by: Joe Huang <[email protected]> * mod * update * clean up * update * update * add on-chain data decoding unit test coverage * add comment * fix import * more test * update * update * fix * fix import * rm unused * remove unused * downgrade * downgrade * rm * update * update * rm * update * revert * revert * revert * fix * update * fix * update * update * mod clean * fix * mod tidy * fix * fix * update * fix * update with develop * fix * go mod * update * update * update * update * update * more * update * update * mod * update * refactor extradata codec * update * goimport * update * add error * tidy * fix import * revert previous extra data codec refactor * fix --------- Co-authored-by: Prashant Yadav <[email protected]>
* cleanup * update * fix mod * update * revert mod change * add changeset * fix smoke test * fix lint * revert go mod * fix * revert * revert * again * update * remove file * revert * update * update * update version * revert * downgrade version * go mod tidy * tidy * add token indexes * update comment * add solana and remove evm specific * add solana config * grammar * update go mod * go mod * update * update * changeset * update * refactor * update * refactor * update lint * fix lint * add chain reader config to plugin creator * update changeset * Part 1 for Prashant comments * refactor getTransmitterKeys * go mod tidy * minor * fix lint * go import * gomod * Blaž comments * part 1 * fix lint * data type * add solana home chain merge func * rephrase * add entire config from example * rm comments * lint * lint * refactor * update comments * fix lint * make generate * Add solana support to contract transmitter (#15869) * add solana support to contract transmitter * add changeset * one more place * address unsupported chain family * encode offramp addr * fix breaking change * rename * test * revert * update version * go mod * go mod tidy * go mod * go.md * go md * remove hard coded * go.md * go import * remove unused * update mod * update with new generated go binding * Amit comments * Solana estimate providers no-op (#15909) * no-op for solana estimate providers * add changeset * token data noop * noop for solana rmn * fix lint * mod tidy * Use SVM ABI, needs to check test * add comment * goimport * update * rename * go mod tidy * goimport * tidy * refactor * fix lint * step 1 for parse extra args map * add comment * fix test * fix * update * improvement * update * update * tidy * update * fix test * Matt comments * address Makram comments * Makram comments part1 * refactor * lint * go mod * update * fix * mod tidy * go md * gomd * fix import * fix broken integration test * change commit to little endian, to do for execute * update * use LE * update * update * update padding * fix make * fix test * rename * fix test * update source chain * update * lower case * update test * goimport * minor * tidy * implement and add test * update comments * goimport * implement dest exec data handling * fix conflicts * fix * fix * fix test * update * fix test * update * add comment * fix mod * fix * refactor * refactor * update * update comment * add unit test * update * lint * mod * mod tidy * fix * lint * update * update * goimport * update * Solana MessageHasher (#15911) * initial code * update * minor * update test * update * lint * change set * update * update * update token data and test * update * fix test --------- Co-authored-by: Joe Huang <[email protected]> * mod * update * clean up * update * update * add on-chain data decoding unit test coverage * add comment * fix import * more test * update * update * fix * fix import * rm unused * remove unused * downgrade * downgrade * rm * update * update * rm * update * revert * revert * revert * fix * update * fix * update * update * mod clean * fix * mod tidy * fix * fix * update * fix * update with develop * fix * go mod * update * update * update * update * update * more * update * update * mod * update * refactor extradata codec * update * goimport * update * add error * tidy * fix import * revert previous extra data codec refactor * fix --------- Co-authored-by: Prashant Yadav <[email protected]>
Jira https://smartcontract-it.atlassian.net/browse/NONEVM-943