Add CI Action to build Solana contracts #15886
Conversation
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
…ainlink into jlavera/add-ci-action-to-build-contracts
|
I see you updated files related to
|
| # short_revision=$(grep "github.com/smartcontractkit/chainlink-ccip/chains/solana" deployment/go.mod | awk '{print $2}' | sed 's/^v//' | awk -F- '{print $NF}') | ||
| short_revision=8973fd0c912b | ||
|
|
||
| # long_revision=$(gh api /repos/smartcontractkit/chainlink-ccip/commits/$short_revision | jq -r .sha) |
There was a problem hiding this comment.
the Github checkout action doesn't support short sha.
in order to use the gh api CLI, we need the gh token, which doesn't seem to be available at this point.
I'll improve this later
There was a problem hiding this comment.
@jlaveracll can remove the comments please ?
can add anything you want as a TODO in the comments please ?
this context will be lost to the person reviewing the branch against develop
There was a problem hiding this comment.
instead of CCIP_REVISION can we call it CHAINLINK_CCIP_COMMIT please (long/short)
There was a problem hiding this comment.
I don't intend these changes to make it to develop, I just want to unblock you guys.
Addressed the feedback and will continue cleaning this up in a different branch
jlaveracll
force-pushed
the
jlavera/add-ci-action-to-build-contracts
branch
from
671cf8b to
013c8ab
Compare
|
Requires
Supports