Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solana router deploy (D) #15871

Open
wants to merge 12 commits into
base: solana-state-updates
Choose a base branch
from

Conversation

yashnevatia
Copy link
Contributor

@yashnevatia yashnevatia commented Jan 8, 2025

Adding router deploy for solana

NOTE: uploading the .so and the corresponding keypair for initial dev efforts

Requires

#15870

Supports

@yashnevatia yashnevatia requested review from a team as code owners January 8, 2025 21:04
@yashnevatia yashnevatia changed the title Solana router deploy Solana router deploy (D) Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

AER Report: CI Core

aer_workflow , commit , Detect Changes , Clean Go Tidy & Generate , Scheduled Run Frequency , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , lint , SonarQube Scan

1. Redeclared function generateAndStoreKeypair:

[Golang Lint (deployment)] [Run golangci-lint] [2025-01-09T17:17:08.0360308Z]

Source of Error:
##[error]deployment/keystone/changeset/internal/test/utils.go:18:2: could not import github.com/smartcontractkit/chainlink/deployment/environment/memory (-: # github.com/smartcontractkit/chainlink/deployment/environment/memory
##[error]environment/memory/chain.go:126:6: generateAndStoreKeypair redeclared in this block
##[error]	environment/memory/chain.go:68:6: other declaration of generateAndStoreKeypair) (typecheck)
	"github.com/smartcontractkit/chainlink/deployment/environment/memory"
	^

Why: The function generateAndStoreKeypair is declared twice in the same block, causing a redeclaration error.

Suggested fix: Remove or rename one of the generateAndStoreKeypair function declarations to ensure there is only one unique declaration.

2. Unused variable config:

[Golang Lint (deployment)] [Run golangci-lint] [2025-01-09T17:17:08.0384296Z]

Source of Error:
##[error]deployment/common/changeset/set_config_mcms_test.go:36:2: declared and not used: config (typecheck)
	config := proposalutils.SingleGroupTimelockConfig(t)
	^

Why: The variable config is declared but not used in the code, leading to an unused variable error.

Suggested fix: Use the config variable in the code or remove its declaration if it is not needed.

3. Unused variable timelock:

[Golang Lint (deployment)] [Run golangci-lint] [2025-01-09T17:17:08.0394620Z]

Source of Error:
##[error]deployment/keystone/changeset/accept_ownership_test.go:54:2: declared and not used: timelock (typecheck)
	timelock, err := commonchangeset.MaybeLoadMCMSWithTimelockChainState(env.Chains[registrySel], addrs)
	^

Why: The variable timelock is declared but not used in the code, leading to an unused variable error.

Suggested fix: Use the timelock variable in the code or remove its declaration if it is not needed.

4. Unused variable contracts:

[Golang Lint (deployment)] [Run golangci-lint] [2025-01-09T17:17:08.0397729Z]

Source of Error:
##[error]deployment/keystone/changeset/append_node_capabilities_test.go:91:3: declared and not used: contracts (typecheck)
		contracts := te.ContractSets()[te.RegistrySelector]
		^

Why: The variable contracts is declared but not used in the code, leading to an unused variable error.

Suggested fix: Use the contracts variable in the code or remove its declaration if it is not needed.

5. Build failures due to redeclared function:

[Core Tests (go_core_ccip_deployment_tests)] [Run tests] [2025-01-09T17:16:37.3452123Z]

Source of Error:
##[error]environment/memory/chain.go:126:6: generateAndStoreKeypair redeclared in this block
##[error]	environment/memory/chain.go:68:6: other declaration of generateAndStoreKeypair

Why: The function generateAndStoreKeypair is declared twice in the same block, causing a redeclaration error and subsequent build failures.

Suggested fix: Remove or rename one of the generateAndStoreKeypair function declarations to ensure there is only one unique declaration.

6. Uncommitted changes after git add --all:

[Clean Go Tidy & Generate] [Ensure clean after generate] [2025-01-09T17:21:54.1060177Z]

Source of Error:
go.md | 4 ++++
1 file changed, 4 insertions(+)

Why: There are uncommitted changes in the go.md file after running git add --all, indicating that the repository is not clean.

Suggested fix: Commit the changes in the go.md file or ensure that no changes are made during the generate step.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@cl-sonarqube-production
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant