deployment/memory: Solana support #15850
Draft
+462
−554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
commented
Jan 7, 2025
| @@ -516,7 +516,7 @@ func deployChainContractsSolana( | |||
| if chainState.CcipRouter.IsZero() { | |||
| // deploy and initialize router | |||
|
|
|||
| programID, err := deployment.DeploySolProgramCLI("ccip_router") | |||
| programID, err := deployment.DeploySolProgramCLI(chain, "ccip_router") | |||
There was a problem hiding this comment.
Should probably turn this into chain.DeployProgram("ccip_router")
AER Report: CI Coreaer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , test-scripts , GolangCI Lint (core/scripts) , GolangCI Lint (.) , Core Tests (go_core_tests) , GolangCI Lint (integration-tests) , Core Tests (go_core_tests_integration) , GolangCI Lint (deployment) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , lint , SonarQube Scan 1. Error deploying program: No such file or directory (os error 2):[go_core_ccip_deployment_tests]Source of Error:Why: The error indicates that the deployment process is attempting to use a program ID that does not exist or cannot be found in the specified directory. This is likely due to a missing or incorrectly specified program ID file. Suggested fix: Ensure that the program ID file exists in the specified directory and that the path to the file is correctly specified in the deployment script. 2. Error deploying program: Invalid value for '--program-id <PROGRAM_ID>': No such file or directory (os error 2):[go_core_ccip_deployment_tests]Source of Error:Why: The error indicates that the deployment process is attempting to use a program ID that does not exist or cannot be found in the specified directory. This is likely due to a missing or incorrectly specified program ID file. Suggested fix: Ensure that the program ID file exists in the specified directory and that the path to the file is correctly specified in the deployment script. 3. Panic: decode: zero length string:[go_core_ccip_deployment_tests]Source of Error:Why: The panic is caused by attempting to decode a zero-length string into a Solana public key. This indicates that an expected value was not provided or was empty. Suggested fix: Ensure that all required values, especially those that are being decoded into public keys, are provided and are not empty. 4. Error: port is already allocated:[go_core_ccip_deployment_tests]Source of Error:Why: The error indicates that the specified port is already in use by another process, preventing the container from starting. Suggested fix: Ensure that the ports required for the tests are free before starting the tests. You may need to modify the test setup to dynamically allocate available ports or ensure that previous tests release the ports properly. 5. Panic: freeport: cannot allocate port block:[go_core_ccip_deployment_tests]Source of Error: |
archseer
force-pushed
the
deployment-memory-solana
branch
3 times, most recently
from
7a5f109 to
3d4a248
Compare
archseer
force-pushed
the
deployment-memory-solana
branch
2 times, most recently
from
5b0fd2d to
3374431
Compare
archseer
force-pushed
the
deployment-memory-solana
branch
from
3374431 to
75bf435
Compare
|
I see you updated files related to
|
archseer
force-pushed
the
deployment-memory-solana
branch
from
c47f4a0 to
04219ae
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.