Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solana link deploy (B) #15845

Merged
merged 32 commits into from
Jan 9, 2025
Merged

Solana link deploy (B) #15845

merged 32 commits into from
Jan 9, 2025
+81 −12

Conversation

yashnevatia
Copy link
Contributor

@yashnevatia yashnevatia commented Jan 6, 2025 •
edited
Loading

Adding changeset to deploy LINK token on Solana

Requires

#15831

Supports

@yashnevatia yashnevatia requested review from a team as code owners January 6, 2025 15:13
@yashnevatia yashnevatia requested a review from jmank88 January 6, 2025 15:13
@yashnevatia yashnevatia mentioned this pull request Jan 6, 2025
Merged
@yashnevatia yashnevatia requested a review from a team as a code owner January 7, 2025 14:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

tt-cll
tt-cll previously approved these changes Jan 7, 2025
View reviewed changes
@smartcontractkit smartcontractkit deleted a comment from github-actions bot Jan 8, 2025
@yashnevatia yashnevatia changed the base branch from develop to solana-updates January 8, 2025 14:12
@yashnevatia yashnevatia changed the title Solana link deploy Solana link deploy (B) Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025 •
edited
Loading

AER Report: CI Core ran successfully ✅

aer_workflow , commit

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

@yashnevatia yashnevatia mentioned this pull request Jan 8, 2025
Open
Base automatically changed from solana-updates to develop January 9, 2025 10:31
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@archseer archseer added this pull request to the merge queue Jan 9, 2025
tt-cll
tt-cll reviewed Jan 9, 2025
View reviewed changes
deployment/common/changeset/deploy_link_token.go
if err != nil {
return deployment.ChangesetOutput{AddressBook: newAddresses}, err
}
switch family {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should have a default case that errs probably (or defaults to the evm implementation)

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2025
@archseer archseer added this pull request to the merge queue Jan 9, 2025
Merged via the queue into develop with commit f2da1e1 Jan 9, 2025
171 checks passed
@archseer archseer deleted the solana-link-deploy branch January 9, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tt-cll tt-cll tt-cll approved these changes

@ecPablo ecPablo ecPablo left review comments

@archseer archseer archseer approved these changes

@jmank88 jmank88 Awaiting requested review from jmank88 jmank88 was automatically assigned from smartcontractkit/foundations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yashnevatia @archseer @ecPablo @tt-cll