follow up the chain selector refactor for CCIP plugin, fix potential bug in CR/CW config #15482
Conversation
huangzhen1997
requested review from
winder,
rstout,
asoliman92,
makramkd,
dimkouv,
mateusz-sekara and
0xAustinWang
AER Report: CI Core ran successfully ✅AER Report: Operator UI CI ran successfully ✅ |
…NONEVM-826/update-chain-family-logic-plugin
| @@ -344,7 +344,7 @@ func (i *pluginOracleCreator) createReadersAndWriters( | |||
| return nil, nil, err1 | |||
| } | |||
|
|
|||
| if chainID == destChainID { | |||
| if chainID == destChainID && destChainFamily == relayChainFamily { | |||
There was a problem hiding this comment.
Whats the difference between a chainID and a chain selector?
Is it true that this extra check is to ensure we don't mis-match in case the same chainID is used in different chain families?
There was a problem hiding this comment.
Yes, chain selector is a randomly generated uint64 and used by CCIP, and it is unique across all chains/families.
The chain id is specific to a chain family, so it doesn't provide this guarantee. For example chainid: 1 can either beethereum-mainnet or aptos-mainnet
There was a problem hiding this comment.
Thanks, I was mixing up chainID and chainSelector. They're both differen't ways to ID a chain so it's hard to reason about, some kind of (chainID, chainFamily) tuple type and/or converting to one or the other rather than passing them around is needed. Having an ID with type string doesn't help.
I believe getChainReaderConfig has this same bug.
prashantkumar1982
deleted the
NONEVM-826/update-chain-family-logic-plugin
branch
https://smartcontract-it.atlassian.net/browse/NONEVM-826
Follow up PR for PR for chain selector refactor work in CCIP plugin change, there's a mistake that potentially causes mis-configuration in CR/CW config