CCIP Load Test connected to crib #15404

0xAustinWang · 2024-11-25T15:43:07Z

https://smartcontract-it.atlassian.net/browse/CCIP-4107

github-actions · 2024-11-25T15:56:41Z

AER Report: CI Core

aer_workflow , commit , Clean Go Tidy & Generate , Detect Changes , Scheduled Run Frequency , GolangCI Lint (.) , GolangCI Lint (integration-tests/load) , GolangCI Lint (integration-tests) , GolangCI Lint (deployment) , Core Tests (go_core_tests) , Core Tests (go_core_tests_integration) , Core Tests (go_core_ccip_deployment_tests) , Core Tests (go_core_fuzz) , Core Tests (go_core_race_tests) , test-scripts , lint , SonarQube Scan

1. Not enough arguments in call to env.GetConfig:[Golang Lint (deployment)]

Source of Error:

environment/crib/env_test.go:13:12: not enough arguments in call to env.GetConfig
	have ()
	want (map[uint64]string)

**Why**: The function `env.GetConfig` is being called without any arguments, but it requires a `map[uint64]string` as an argument.

Suggested fix: Pass the required map[uint64]string argument to the env.GetConfig function call.

2. Assignment mismatch: 1 variable but env.GetConfig returns 2 values:[Golang Lint (deployment)]

Source of Error:

environment/crib/env_test.go:13:12: assignment mismatch: 1 variable but env.GetConfig returns 2 values (typecheck)

**Why**: The function `env.GetConfig` returns two values, but only one variable is being used to capture the return values.

Suggested fix: Use two variables to capture both return values from env.GetConfig.

3. No go files to analyze:[Golang Lint (integration-tests/load)]

Source of Error:

level=error msg="Running error: context loading failed: no go files to analyze: running `go mod tidy` may solve the problem"

**Why**: The linter could not find any Go files to analyze in the specified directory.

Suggested fix: Ensure that there are Go files in the integration-tests/load directory or run go mod tidy to clean up the module dependencies.

4. Cannot use cd.wsRPCs as []devenv.CribRPCs value in struct literal:[Golang Lint (integration-tests)]

Source of Error:

testsetups/ccip/test_helpers.go:658:15: cannot use cd.wsRPCs (variable of type []string) as []devenv.CribRPCs value in struct literal

**Why**: The variable `cd.wsRPCs` of type `[]string` is being used where a `[]devenv.CribRPCs` type is expected.

Suggested fix: Convert cd.wsRPCs to the expected type []devenv.CribRPCs.

5. Cannot use cd.httpRPCs as []devenv.CribRPCs value in struct literal:[Golang Lint (integration-tests)]

Source of Error:

testsetups/ccip/test_helpers.go:659:15: cannot use cd.httpRPCs (variable of type []string) as []devenv.CribRPCs value in struct literal (typecheck)

**Why**: The variable `cd.httpRPCs` of type `[]string` is being used where a `[]devenv.CribRPCs` type is expected.

Suggested fix: Convert cd.httpRPCs to the expected type []devenv.CribRPCs.

6. Declared and not used: ownerChainB:[Golang Lint (integration-tests)]

Source of Error:

integration-tests/smoke/ccip/ccip_usdc_test.go:52:2: declared and not used: ownerChainB (typecheck)

**Why**: The variable `ownerChainB` is declared but not used in the code.

Suggested fix: Remove the declaration of ownerChainB if it is not needed, or use it appropriately in the code.

7. Updates to go.mod needed; to update it:[Clean Go Tidy & Generate]

Source of Error:

go: updates to go.mod needed; to update it:
	go mod tidy
error: exit status 1

**Why**: The `go.mod` file is not up-to-date and requires running `go mod tidy` to clean up and update the module dependencies.

Suggested fix: Run go mod tidy to update the go.mod file and clean up any unnecessary dependencies.

AER Report: Operator UI CI ran successfully ✅

aer_workflow , commit

deployment/environment.go

integration-tests/load/ccip/helpers.go

AnieeG · 2024-12-03T16:50:16Z

integration-tests/load/ccip/helpers.go

+		"sourceSelector":      fmt.Sprintf("%d", src),
+		"destinationSelector": fmt.Sprintf("%d", dst),


would it be easier to use names/chain id instead? Labelling by selector can create confusion as selector is a large number

AnieeG · 2024-12-03T16:50:52Z

integration-tests/load/ccip/helpers.go

+
+func SendMetricsToLoki(l zerolog.Logger, lc *wasp.LokiClient, updatedLabels map[string]string, metrics *LokiMetric) {
+	if err := lc.HandleStruct(wasp.LabelsMapToModel(updatedLabels), time.Now(), metrics); err != nil {
+		l.Error().Err(err).Msg(ErrLokiPush)


do you not want the test to fail if it fails to push?

AnieeG · 2024-12-03T16:52:50Z

integration-tests/load/ccip/destination_gun.go

+
+	return router.ClientEVM2AnyMessage{
+		Receiver:     rcv,
+		Data:         common.Hex2Bytes("hello world"),


How about using some identifier here like msg with id to distinguish.

AnieeG · 2024-12-03T17:02:46Z

integration-tests/load/ccip/destination_gun.go

+		m.env.Chains[src].DeployerKey.Value = fee
+		defer func() { m.env.Chains[src].DeployerKey.Value = nil }()
+	}
+	_, err = r.CcipSend(


Are you approving router to spend fee tokens in the beginning?

integration-tests/load/ccip/destination_gun.go

AnieeG · 2024-12-03T17:05:22Z

integration-tests/load/ccip/ccip_test.go

+// Parse all events from the simulated chains, send to Loki
+// step 4: teardown
+// Stop the chains, cleanup the environment
+func TestCCIPLoad_RPS(t *testing.T) {


A lot of code in this can be extracted to common functions. You might need more than one load test in future

integration-tests/load/ccip/ccip_test.go

cl-sonarqube-production · 2025-01-14T10:17:13Z

Quality Gate passed

Issues
4 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

deployment/environment/crib/helpers.go

0xAustinWang · 2025-01-16T15:07:25Z

closing in favor of : #15954

0xAustinWang requested review from a team as code owners November 25, 2024 15:43

0xAustinWang requested review from winder, rstout, asoliman92, makramkd, dimkouv, mateusz-sekara and 0xnogo November 25, 2024 15:43

AnieeG reviewed Dec 3, 2024

View reviewed changes

0xAustinWang force-pushed the aw/CCIPLoad branch from 1eee96f to 2b94462 Compare December 11, 2024 11:14

0xAustinWang requested a review from a team as a code owner December 11, 2024 11:14

0xAustinWang marked this pull request as draft December 11, 2024 11:18

0xAustinWang force-pushed the aw/CCIPLoad branch from 2b94462 to 4f21404 Compare December 17, 2024 08:51

0xAustinWang force-pushed the aw/CCIPLoad branch 2 times, most recently from f4a9b8e to 87eab87 Compare January 10, 2025 04:49

0xAustinWang added 11 commits January 13, 2025 14:24

add new ccip load test, compiles

38bd5b5

fix build

7f1b1be

make test runnable

2270338

rename

5f0ca74

in progress

e8a0bb3

build

d5b7c47

load test transmitting

3b09526

load test, have transaction, need to use event watcher

c53e8d4

progress, going to rebase

61d9da0

changeset applies only once

4314e83

should nto use testrouter when adding lanes

d57b108

test changes

1ea5e2f

0xAustinWang force-pushed the aw/CCIPLoad branch from 87eab87 to 1ea5e2f Compare January 13, 2025 06:24

set ocr3 configuration so the bootstrap can create a don

8110337

0xAustinWang added 2 commits January 15, 2025 12:45

load test WORKING

2c02914

use changeset cspairs in the ccip tests

2ce7370

0xAustinWang changed the title ~~CCIP Load Test connected to crib (not yet working)~~ CCIP Load Test connected to crib Jan 15, 2025

github-advanced-security bot found potential problems Jan 15, 2025

View reviewed changes

deployment/environment/crib/helpers.go Fixed Show fixed Hide fixed

0xAustinWang added 2 commits January 16, 2025 00:28

optimizations for load test

92649b9

cleanup

6e439df

0xAustinWang closed this Jan 16, 2025

0xAustinWang deleted the aw/CCIPLoad branch January 16, 2025 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CCIP Load Test connected to crib #15404

CCIP Load Test connected to crib #15404

0xAustinWang commented Nov 25, 2024

github-actions bot commented Nov 25, 2024 •

edited

Loading

AnieeG Dec 3, 2024

AnieeG Dec 3, 2024

AnieeG Dec 3, 2024

AnieeG Dec 3, 2024

AnieeG Dec 3, 2024

cl-sonarqube-production bot commented Jan 14, 2025

0xAustinWang commented Jan 16, 2025

		"sourceSelector": fmt.Sprintf("%d", src),
		"destinationSelector": fmt.Sprintf("%d", dst),

CCIP Load Test connected to crib #15404

CCIP Load Test connected to crib #15404

Conversation

0xAustinWang commented Nov 25, 2024

github-actions bot commented Nov 25, 2024 • edited Loading

AER Report: CI Core

1. Not enough arguments in call to env.GetConfig:[Golang Lint (deployment)]

2. Assignment mismatch: 1 variable but env.GetConfig returns 2 values:[Golang Lint (deployment)]

3. No go files to analyze:[Golang Lint (integration-tests/load)]

4. Cannot use cd.wsRPCs as []devenv.CribRPCs value in struct literal:[Golang Lint (integration-tests)]

5. Cannot use cd.httpRPCs as []devenv.CribRPCs value in struct literal:[Golang Lint (integration-tests)]

6. Declared and not used: ownerChainB:[Golang Lint (integration-tests)]

7. Updates to go.mod needed; to update it:[Clean Go Tidy & Generate]

AER Report: Operator UI CI ran successfully ✅

AnieeG Dec 3, 2024

Choose a reason for hiding this comment

AnieeG Dec 3, 2024

Choose a reason for hiding this comment

AnieeG Dec 3, 2024

Choose a reason for hiding this comment

AnieeG Dec 3, 2024

Choose a reason for hiding this comment

AnieeG Dec 3, 2024

Choose a reason for hiding this comment

cl-sonarqube-production bot commented Jan 14, 2025

Quality Gate passed

0xAustinWang commented Jan 16, 2025

github-actions bot commented Nov 25, 2024 •

edited

Loading