Keystone e2e test #15182
Open
Keystone e2e test #15182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
reviewed
Nov 27, 2024
# Conflicts: # integration-tests/go.mod
skudasov
force-pushed
the
dk-keystone-e2e-test
branch
from
48a0339 to
c92fea5
Compare
skudasov
force-pushed
the
dk-keystone-e2e-test
branch
from
7237990 to
49b858e
Compare
jmank88
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Please don't commit binaries
krehermann
reviewed
Dec 20, 2024
| ExistingHashedCapabilitiesIDs [][32]byte | ||
| } | ||
|
|
||
| func Deploy(sc *seth.Client) (*CapabilitiesRegistryInstance, error) { |
There was a problem hiding this comment.
can we not reuse, extend and unify on the work in deployment/keystone?
ccip is doing something similiar -- all deployment logic is unified and they have a devenv for integration tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-ups
buildstep instead of re-creating it.