Ks/update nodes cs cleanup #15080
Merged
Ks/update nodes cs cleanup #15080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krehermann
force-pushed
the
ks/update-nodes-cs-cleanup
branch
from
9ab3e45 to
5cbf266
Compare
krehermann
force-pushed
the
ks/update-nodes-cs-cleanup
branch
from
5cbf266 to
de7b7b0
Compare
krehermann
commented
Nov 5, 2024
| return nil | ||
| } | ||
|
|
||
| type UpdateNodeCapabilitiesImplRequest struct { |
| type UpdateNodeCapabilitiesRequest = MutateNodeCapabilitiesRequest | ||
|
|
||
| // MutateNodeCapabilitiesRequest is a request to change the capabilities of nodes in the registry | ||
| type MutateNodeCapabilitiesRequest struct { |
There was a problem hiding this comment.
both update and append use the same form. unify and leverage type aliases
| } | ||
| } | ||
| return out, nil | ||
| } | ||
|
|
||
| func NodeOperator(name string, adminAddress string) capabilities_registry.CapabilitiesRegistryNodeOperator { |
There was a problem hiding this comment.
refactor common util into func.
| @@ -40,7 +41,7 @@ func (cs ContractSet) View() (view.KeystoneChainView, error) { | |||
| return out, nil | |||
| } | |||
|
|
|||
| func GetContractSets(req *GetContractSetsRequest) (*GetContractSetsResponse, error) { | |||
| func GetContractSets(lggr logger.Logger, req *GetContractSetsRequest) (*GetContractSetsResponse, error) { | |||
bolekk
approved these changes
Nov 5, 2024
vyzaldysanchez
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup and simplify code. Extract funcs that are needed in
chainlink-deployment. Fix typos, comment and adding logging